feat(feature): Added functions and logic so that to make concerto-rust pass all the conformance tests by Anshukumar123975 · Pull Request #2 · accordproject/concerto-rust

Anshukumar123975 · 2025-11-03T12:40:19Z

Title:

Added functions and logic within ModelFile and ModelManager to make the Rust runtime of Concerto capable of passing all conformance tests.

Description:

This PR introduces the necessary functions, logic, and updates required to ensure that concerto-rust successfully passes all conformance tests.
The primary focus of this update is on strengthening the ModelFile and ModelManager modules of rust runtime. These components now provide full support for key Concerto specifications like Concepts, Enums, Namespaces, Imports, Maps and Scalars.
This update makes the Rust runtime conformant with the Concerto specification to a large extent.

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

ekarademir

First pass

ekarademir · 2025-11-05T11:30:37Z

src/metamodel/concerto_metamodel_1_0_0.rs

+}
+
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct Properties {


Are these types generated by Concerto?
I'm asking because there is already a Property struct here, is there a need for Properties?

I think Property should be replaced with Properties as there were more parameters required for Properties and now in this code Property has become a subset of Properties.

This is a generated file so we shouldn't modify this here. Property is from the concerto metamodel. I think the problem is lack of inheritance in Rust. So, unified struct is not possible. We would need some other way to achieve this. Possibly an Enum type, defined in a separate file.

ekarademir · 2025-11-05T11:37:51Z

src/metamodel/concerto_metamodel_1_0_0.rs

      rename = "types",
   )]
-   pub types: Vec<String>,
+   pub types: Option<Vec<String>>,


Comparing to the metamodel, name is not part of ImportTypesit's part ofImportType`. For Rust implementation we might need a Rust enum that has different Import flavours.

Ok, I will be updating this

I've completely removed ImportTypes and we are now using only ImportType.

We shouldn't remove any types from this module.

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

ekarademir

@Anshukumar123975 let me think of a better way to combine metamodel structs together. We shouldn't modify this file as much as possible. We it should be modified, it should be done in the concerto-codegen library.

A possible solution is using enums.

ekarademir · 2025-11-12T11:25:44Z

src/metamodel/concerto_metamodel_1_0_0.rs

 }

-#[derive(Debug, Serialize, Deserialize)]
+#[derive(Debug, Clone, Serialize, Deserialize)]


I guess the Clone trait is needed here. However, we should add this to the Rust target for concerto-codegen, instead of modifying this file.

ekarademir · 2025-11-12T11:30:05Z

src/metamodel/concerto_metamodel_1_0_0.rs

+}
+
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct Properties {


This is a generated file so we shouldn't modify this here. Property is from the concerto metamodel. I think the problem is lack of inheritance in Rust. So, unified struct is not possible. We would need some other way to achieve this. Possibly an Enum type, defined in a separate file.

ekarademir · 2025-11-12T11:31:32Z

src/metamodel/concerto_metamodel_1_0_0.rs

   )]
   pub name: String,

+   #[serde(


The Declaration type from concerto metamodel doesn't have these extra fields.

ekarademir · 2025-11-12T11:31:56Z

src/metamodel/concerto_metamodel_1_0_0.rs

      rename = "types",
   )]
-   pub types: Vec<String>,
+   pub types: Option<Vec<String>>,


We shouldn't remove any types from this module.

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Anshukumar123975 added 30 commits October 1, 2025 12:44

Add logic for duplicate enum names

65cf7d2

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

changes

ec5f217

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

51171e8

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

91a6733

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

1fde695

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

57cebbc

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

e1d69be

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

1bf19f4

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

68ec42a

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

78925e7

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

8360430

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

fea704e

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

77aa37b

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

45f8f2d

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

98299f1

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

d892475

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

4c95ba6

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

dbc719e

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

c9d572b

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

a957349

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

cef7191

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

0fd8f75

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

9c340b9

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

39c1047

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

00e37d3

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

33b7205

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

b459908

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

43fa001

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

4a779f2

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

ecd5dba

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Anshukumar123975 added 13 commits November 3, 2025 14:33

Testing changes

4f6cbda

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

e44a8c5

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

5a27644

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

e97bfcc

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

3b76121

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

2f420e3

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

3535260

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

270814e

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

893816b

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

5055296

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

fd47525

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

2249dd8

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Testing changes

be108c9

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

mttrbrts requested a review from ekarademir November 3, 2025 13:22

ekarademir reviewed Nov 5, 2025

View reviewed changes

Anshukumar123975 added 3 commits November 5, 2025 17:52

Removed ImportedTypes

8f42e73

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Replaced Property with Properties

0341521

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Replaced Property with Properties

02aec57

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

ekarademir reviewed Nov 12, 2025

View reviewed changes

Added extended_metamodel

9727087

Signed-off-by: Anshukumar123975 <anshupat2020@gmail.com>

Conversation

Anshukumar123975 commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Title:

Description:

Uh oh!

ekarademir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Anshukumar123975 Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ekarademir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Anshukumar123975 commented Nov 3, 2025 •

edited

Loading

Anshukumar123975 Nov 5, 2025 •

edited

Loading