DX Weather (local-only): restore hover bubble + popup weather for POTA/WWFF/SOTA/WWBOTA#580
Open
Delerius wants to merge 2 commits intoaccius:Stagingfrom
Open
DX Weather (local-only): restore hover bubble + popup weather for POTA/WWFF/SOTA/WWBOTA#580Delerius wants to merge 2 commits intoaccius:Stagingfrom
Delerius wants to merge 2 commits intoaccius:Stagingfrom
Conversation
Contributor
Author
|
Just for clarity on the earlier revert, after looking through the history, it appears WWBOTA (#550) landed before DX Weather (#567), and since DX Weather touched shared icon handling logic (but not WWBOTA directly), the revert was likely due to base changes rather than DX Weather itself being invalid. I’ve now rebased cleanly against the current Staging and scoped the icon logic per marker to avoid overlap going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores hover bubble overlay + popup weather injection for POTA, WWFF, SOTA, and WWBOTA markers.
Uses consistent hover object shape (call/dxCall/lat/lon/source) and calls attachHoverHandlers() + attachPopupWeather() for each marker type.
Keeps DX highlight behavior intact; marker popups lock highlight when open.
Includes minor DX cluster filter adjustment (see dxClusterFilters.js).
Testing:
Verified POTA/WWFF/SOTA/WWBOTA markers show hover bubble and popup weather.
Verified DX Cluster dots retain hover bubble + popup weather and highlight line behavior.