Skip to content

Comments

"did i break it" - yes you did, so i brought it back. :-)#574

Merged
accius merged 1 commit intoaccius:Stagingfrom
echo-gravitas:fix/commit-4fab8f5
Feb 23, 2026
Merged

"did i break it" - yes you did, so i brought it back. :-)#574
accius merged 1 commit intoaccius:Stagingfrom
echo-gravitas:fix/commit-4fab8f5

Conversation

@echo-gravitas
Copy link
Contributor

@echo-gravitas echo-gravitas commented Feb 22, 2026

@echo-gravitas echo-gravitas changed the title "did i break it" - yes you did, so i brougt it back. :-) "did i break it" - yes you did, so i brought it back. :-) Feb 22, 2026
Copy link
Contributor

@ceotjoe ceotjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echo-gravitas is it correct that the imports get removed? E.g. React and rig control? Looks like other rig control elements get also removed. I'm just wondering. Probably I'm wrong. :-)

@echo-gravitas
Copy link
Contributor Author

echo-gravitas commented Feb 22, 2026

@ceotjoe - let me check that quickly. I didn't noticed anything suspicious while testing.

@ceotjoe
Copy link
Contributor

ceotjoe commented Feb 22, 2026

@echo-gravitas I just looked into the diff.

@echo-gravitas
Copy link
Contributor Author

echo-gravitas commented Feb 22, 2026

@accius
@ceotjoe
All good. Click to tune works as expected.
onSpotClick is used from DXClusterPanel param.

@echo-gravitas
Copy link
Contributor Author

@ceotjoe Since React 17, JSX no longer requires import React because the new JSX transform handles it automatically via react/jsx-runtime. But hooks like useState are real runtime functions, so they still need to be explicitly imported.

Copy link
Contributor

@ceotjoe ceotjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's fine if you tested it again. I was just looking into the diff and was wondering why these imports were removed. :-) All good.

@accius accius merged commit 4ca28d0 into accius:Staging Feb 23, 2026
@echo-gravitas echo-gravitas deleted the fix/commit-4fab8f5 branch February 23, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants