"did i break it" - yes you did, so i brought it back. :-)#574
"did i break it" - yes you did, so i brought it back. :-)#574accius merged 1 commit intoaccius:Stagingfrom
Conversation
ceotjoe
left a comment
There was a problem hiding this comment.
@echo-gravitas is it correct that the imports get removed? E.g. React and rig control? Looks like other rig control elements get also removed. I'm just wondering. Probably I'm wrong. :-)
|
@ceotjoe - let me check that quickly. I didn't noticed anything suspicious while testing. |
|
@echo-gravitas I just looked into the diff. |
|
@ceotjoe Since React 17, JSX no longer requires import React because the new JSX transform handles it automatically via react/jsx-runtime. But hooks like useState are real runtime functions, so they still need to be explicitly imported. |
ceotjoe
left a comment
There was a problem hiding this comment.
For me it's fine if you tested it again. I was just looking into the diff and was wondering why these imports were removed. :-) All good.
fixes echo-gravitas@4fab8f5