Skip to content

Align profile tab focus visible ring #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chucks1093 merged 1 commit into from
May 28, 2026
Merged

Align profile tab focus visible ring #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/common/ProfileTabPill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { cva, type VariantProps } from 'class-variance-authority';
import { cn } from '@/lib/utils';

const profileTabPillVariants = cva(
'inline-flex items-center gap-1.5 rounded-full border px-3.5 py-1.5 text-xs font-semibold font-jakarta tracking-wide transition-all duration-200 outline-none focus-visible:ring-2 focus-visible:ring-amber-400/50 focus-visible:ring-offset-1 focus-visible:ring-offset-transparent',
'inline-flex items-center gap-1.5 rounded-full border px-3.5 py-1.5 text-xs font-semibold font-jakarta tracking-wide transition-all duration-200 outline-none focus-visible:border-ring focus-visible:ring-[3px] focus-visible:ring-ring/50 focus-visible:ring-offset-2 focus-visible:ring-offset-background',
{
variants: {
state: {
Expand Down
23 changes: 23 additions & 0 deletions src/components/common/__tests__/ProfileTabPillGroup.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,27 @@ describe('ProfileTabPillGroup – hash routing enabled', () => {
);
}
});

it('uses the project focus-visible ring for keyboard tab focus', () => {
const onTabChange = vi.fn();
render(
<ProfileTabPillGroup
tabs={TABS}
activeTab="overview"
onTabChange={onTabChange}
enableHashRouting
/>
);

const tab = screen.getByRole('tab', { name: 'Overview' });

expect(tab).toHaveClass(
'focus-visible:border-ring',
'focus-visible:ring-[3px]',
'focus-visible:ring-ring/50',
'focus-visible:ring-offset-2',
'focus-visible:ring-offset-background'
);
expect(tab.className).not.toContain('focus:ring-');
});
});
Loading