Fix fourkeys mode for Frue derived ROMs + VIP Card/Door Key naming fix#9
Open
karlcloudy wants to merge 2 commits intoabyssonym:masterfrom
Open
Fix fourkeys mode for Frue derived ROMs + VIP Card/Door Key naming fix#9karlcloudy wants to merge 2 commits intoabyssonym:masterfrom
karlcloudy wants to merge 2 commits intoabyssonym:masterfrom
Conversation
karlcloudy
commented
Feb 25, 2024
karlcloudy
commented
- Frue derived ROMs use a different name for the Basement, Dankirk, and Narcysus keys which wasn't accounted for in four keys generation, which caused assertion failures.
- Stop Door Key and VIP Card being renamed to 'Useless key':
- VIP Card isn't a key and still works for the VIP room at Markao, so still useful
- Door Key is given by default, so while it doesn't matter that much, 'Useless key' shows up in the Scenario screen otherwise:
karlcloudy
force-pushed
the
fix-fourkeys-with-frue
branch
from
a42c6c9 to
3983943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.