Jomanw asteroids#173
Open
jcswong wants to merge 7 commits into
Open
Conversation
and two asteroid spectra in the tutorial folder
/ or \\ convention differs by OS and user, splitting by only "/" could cause issues. Using os.path.abspath('some/path') mitigates this issue as its output is OS dependent. Also, all files from MITHNEOS are named with the observation date, this is currently included with the AsteroidSpectrum name.
removed recently added debugging code. Code was added to uncover an improperly labeled omitted data point in a MITHNEOS spectrum
line 816, int to float. Previously changed from float to int, but, as it turns out, not all data in MITHNEOS have the same number of columns. Some 200-300 are missing the 4th column for number of frames used as an average to create the data point. Hence, the column with index -1 is the noise as a string, hence throws an exception when casted to int from base 10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overview:
file additions: