Delete shortcuts so it works when we load a new config. Add shortcut for watershed#36
Open
dwlsalmeida wants to merge 2 commits intoabreheret:masterfrom
Open
Delete shortcuts so it works when we load a new config. Add shortcut for watershed#36dwlsalmeida wants to merge 2 commits intoabreheret:masterfrom
dwlsalmeida wants to merge 2 commits intoabreheret:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless we hook a delete call for the shortcut when LabelInfo objects go out of scope, we will not be able to add a new shortcut for the same QKeySequence.This is problematic in the event we want to load another config file: shortcuts simply will not work in this case. This quick change fixes this.
I also took the opportunity to delete 'item', since it is a pointer type acquired with new that is not destroyed anywhere (I guessed by briefly looking at the source code, since I am not that familiar with Qt)
Lastly, I added a shortcut for the run watershed button while I was at it.