Skip to content

Fix PyPI latest-date handling when upload_time_iso_8601 is missing #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drawliin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PyPI latest-date handling when upload_time_iso_8601 is missing #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions packagedb/package_managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,12 @@ def get_latest_date(self, downloads):
latest_date = None
for download in downloads:
upload_time = download.get("upload_time_iso_8601")
if upload_time:
current_date = dateparser.parse(upload_time)
if not latest_date:
if not upload_time:
continue

current_date = dateparser.parse(upload_time)
if not latest_date or current_date > latest_date:
latest_date = current_date
else:
if current_date > latest_date:
latest_date = current_date
return latest_date


Expand Down
18 changes: 18 additions & 0 deletions packagedb/tests/test_package_managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,24 @@ def test_pypi_fetch_with_no_release(self, mock_response):
results = list(PypiVersionAPI().fetch("django"))
assert results == []

def test_pypi_get_latest_date_skips_missing_upload_time(self):
downloads = [
{},
{"upload_time_iso_8601": "2010-12-23T05:14:23.509436Z"},
{"upload_time_iso_8601": "2010-12-23T05:20:23.509436Z"},
]

latest_date = PypiVersionAPI().get_latest_date(downloads)

assert latest_date == dt_local(2010, 12, 23, 5, 20, 23, 509436)

def test_pypi_get_latest_date_with_no_valid_upload_time(self):
downloads = [{}, {"url": "https://files.pythonhosted.org/example.whl"}]

latest_date = PypiVersionAPI().get_latest_date(downloads)

assert latest_date is None

@mock.patch("packagedb.package_managers.get_response")
def test_ruby_fetch_with_no_release(self, mock_response):
with open(os.path.join(TEST_DATA, "gem.json")) as f:
Expand Down