fix: issue 795-download_url from purl when not provided#860
Open
RuchitAgrawal wants to merge 1 commit intoaboutcode-org:mainfrom
Open
fix: issue 795-download_url from purl when not provided#860RuchitAgrawal wants to merge 1 commit intoaboutcode-org:mainfrom
RuchitAgrawal wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Ruchit Agrawal <rragrawal16@gmail.com>
RuchitAgrawal
force-pushed
the
fix/issue-795-download-url-from-purl
branch
from
9f04fbd to
e94ed1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #795
Problem
Packages coming from federatedcode repos only carry a PURL and no
download_url. The unique constraint on
Package.download_urlpreventedthese packages from being created in the database.
Solution
packagedb/purl_url_utils.pywith two helper functions:derive_download_url()— tries purl2url first, falls back to synthetic URLgenerate_synthetic_download_url()— builds apurl://...URL from PURL componentsPackage.save()to auto-callderive_download_url()whendownload_urlis emptypackagedb/tests/test_purl_download_url.py