Open
Conversation
- Add PackageMetadataFile model with ForeignKey to Package - Store filename, filetype, content, download_url and sha1 - Add migration for new model - Add test for PackageMetadataFile creation Closes aboutcode-org#840 Signed-off-by: clencyc <clency2023@gmail.com>
The throttle cache was not being reset between test runs, causing request counts from previous tests to spill over and trigger the rate limit prematurely. Fix by calling cache.clear() at the start of setUp(). Fixes #<replace-with-your-issue-number> Signed-off-by: clencyc <clency2023@gmail.com>
clencyc
force-pushed
the
fix-throttle-test-cache-reset
branch
from
f2e5136 to
8b8d061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky test where
test_package_endpoint_throttlingwasfailing with
429 != 200.Root Cause
The throttle cache was not being cleared between test runs. Request
counts from previous tests were spilling over into this test, causing
the rate limit to trigger prematurely before the expected threshold.
Fix
Added
cache.clear()at the start ofsetUp()to reset the throttlecache before each test run.
Testing
All 109 tests now pass.
Fixes #849