Added sqrt method#2
Open
Bencor29 wants to merge 2 commits into
Open
Conversation
|
I've got some additional code to deal with parsing complex numbers in scientific notation (e.g. "2.3e-06+3.2E-06i"). Should I fork your project or the master project to make a pull request? It seems the master project has not been active for may years :-( |
Author
|
Hello @mankind-nil |
|
Cheers, I created a fork and tried to create a pull request, but it says that you archived the project so it's read only! If you can unarchive it, let me know and I'll create another pull request. Cheers! |
Author
|
Hey, sorry for the delay. I unarchived my fork, you should by able to open a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You don't updated your project since 2016 but I wanted to add a missing feature: Square root of complex.