Bringing the tools up2date and adding some new functions #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abakedapplepie
approved these changes
Sep 13, 2019
rdm-tools.php
Outdated
| if (result.spawnpoints != null) { | ||
| result.spawnpoints.forEach(function(item) { | ||
| spawnpoints.push(item); | ||
| if (item.despawn_sec != null){ |
Owner
There was a problem hiding this comment.
Instead of duplicating the marker generation here with a switch for despawn_sec null, we should do something like if (item.despawn_sec != null) { var color = blue } else { var color = red }
Then pass the var to the marker builder. currently youre checking twice for each point, and with spawns being the most prevalant data i'd like to keep it as efficient as possible
README.md
Outdated
| * You don't have to have spawns/stops visible on map to perform reporting anymore. | ||
| * Revised optimization function - same super simple algorithm, might be better performing though | ||
| * Changes to data storage, functions no longer loop through map objects, coordinates for gyms/stops/spawns are stored separately. Should help with performance | ||
| * spawnpoint color is different for verified despawn time |
Owner
There was a problem hiding this comment.
can you fix this section's grammar/punctuation to match the rest of the document?
README.md
Outdated
| *  Enables/disables manual placement of route points. Click on the map to drop a route point in the routing layer based on view radius setting. | ||
| *  Pulls nest data from OSM and places polygons in the current map bounds covering all parks. | ||
| *  Import CSV or GeoJSON polygon data. GeoJSON can contain multiple polygons, each one will be placed individually. | ||
| *  Import CSV or GeoJSON polygon data. GeoJSON can contain multiple polygons, each one will be placed individually. Choose wether to import as editable polygon(s) or nest(s). |
Popups of spawnpoints now show Despawn time: hh:mm:ss instead of seconds.
Un1matr1x
suggested changes
Sep 20, 2019
rdm-tools.php
Outdated
| } | ||
|
|
||
| $sql_spawn = "SELECT pokemon_id, COUNT(pokemon_id) as count FROM rdmdb.pokemon WHERE " . $points_string . " AND first_seen_timestamp >= ? GROUP BY pokemon_id ORDER BY count DESC" . $limit; |
There was a problem hiding this comment.
this sql-qry needs to be fixed ...
instead of rdmdb.pokemon use pokemon
this was wrong all along ... kudoo to f.e. DrKendall
thx to un1matr1x
Un1matr1x
approved these changes
Sep 20, 2019
…ts' from settings to 'GO', did some visual changes and added count of points in circles (thx @xxleevo!)
…ving to click each layer.
…emove a bunch of unnecesary stuff from the screen, freeing memory in the process. Also, it looks way cleaner this way.
…ever showing. Also moved the clearLayer from the previous commit to the complete function.
Fix import empty lines
update config.php usage
lift fontawesome version & fix missing icon & change icons for better understanding
…xes for generating circle s2 cells
Password support
Password support
… option for nest import.
update for docker support
create docker workflow
Update docker-compose.example.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary is in changed README.md
added showing ex-raid-eligible gyms as maroon, thanks to un1matr1x