fix: PowerShell env var cleanup on Ctrl+C/crash#8
Open
hobostay wants to merge 1 commit into
Open
Conversation
The regular launch mode set env vars and cleaned them up after `claude` exits, but if the user presses Ctrl+C or the process crashes, cleanup is skipped and the env vars (including the API key in ANTHROPIC_AUTH_TOKEN) leak into the parent shell session. Wrap in try/finally to match the pattern already used by the remote mode. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try/finallyto ensure env var cleanup always runsProblem
The remote mode already used
try/finallyfor env cleanup, but the regular launch mode did not. If the user presses Ctrl+C orclaudecrashes, the cleanup code after& claude @Argsis skipped. This leaks sensitive env vars into the parent shell session, includingANTHROPIC_AUTH_TOKENwhich contains the API key.Test plan
deepclaude.ps1 -b ds, then Ctrl+C → env vars should be cleaned up🤖 Generated with Claude Code