fix: add request body size limit to proxy#7
Open
hobostay wants to merge 1 commit into
Open
Conversation
The proxy had a 1KB size limit on the control endpoint (/_proxy/mode) but no limit on model API request bodies. A client could send an arbitrarily large request, causing memory exhaustion in the proxy process. Add a 50MB limit with a 413 response on overflow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy/model-proxy.jsProblem
The
/_proxy/modecontrol endpoint already had a 1KB body size limit, but the main model API request path (/v1/messages) collected request body chunks into memory without any bound. A client (or a bug in the calling code) could send an arbitrarily large request body, causing the proxy Node.js process to consume unbounded memory and potentially crash.Test plan
/v1/messagesrequest through the proxy🤖 Generated with Claude Code