fix(samples): Declare uvicorn and http-server extras for a2a-sdk#1660
Merged
Conversation
…ample agents Add direct dependency on uvicorn and use `a2a-sdk[http-server]` to ensure starlette and sse-starlette are installed in the sample agents' environments. Previously, when uv re-resolved dependencies for Python 3.14, it skipped installing starlette and sse-starlette since they weren't explicitly declared, causing server startup to fail during E2E tests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several sample agent configurations (pyproject.toml) to use the [http-server] extra for the a2a-sdk dependency, and adds uvicorn as a dependency where needed. The uv.lock file is updated accordingly, and a minor formatting adjustment is made to a React package.json. There are no review comments on this pull request, and I have no feedback to provide.
josemontespg
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1582 broke the e2e tests (see https://github.com/a2ui-project/a2ui/actions/runs/27483533356/job/81235359620 ).
This PR resolves the issue where E2E tests fail to start because Python HTTP server dependencies (
starlette,sse-starlette, anduvicorn) are missing from the environment after Python 3.14 package resolution.Changes
pyproject.tomlfiles that deploy HTTP servers (restaurant_finder,custom-components-example,orchestrator,gemini_enterprise/cloud_run,rizzcharts, andmcp_app_proxy) to explicitly requirea2a-sdk[http-server]instead ofa2a-sdk.uvicornas a direct dependency in sample agents that use it directly (restaurant_finder,orchestrator,rizzcharts).uv.lock) across the workspace.Impact & Risks
There are no breaking changes or risk of regressions. This change only makes the package dependencies hermetic and robust under Python 3.14.
Testing
The fix has been verified locally by running
./scripts/e2e_test.sh, which previously failed due to package resolution issues, and now completes successfully with all tests passing.Fixes #1648