[Improve] Keep settings regression coverage in webview-ui tests#95
Merged
Conversation
roomote
Bot
added
the
roomote:auto-resolve-conflicts
Contributor
Author
|
1 issue outstanding. Action required. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
force-pushed
the
fix/unskip-settings-tests-3a14nppya0vlf
branch
from
3b8e47b to
5278810
Compare
edelauna
requested review from
JamesRobert20,
edelauna,
navedmerchant and
taltas
as code owners
edelauna
approved these changes
May 14, 2026
edelauna
left a comment
edelauna
left a comment
Contributor
There was a problem hiding this comment.
Unskipping, skipped integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
Fixes an issue where skipped settings regression tests left important
webview-uibehavior uncovered, especially aroundSettingsViewunsaved-change detection and the OpenAI-compatible reasoning-effort controls. It also fills the gap where future agents had no local guidance about when a regression belongs inwebview-uitests instead ofapps/vscode-e2e.Why this change was made
The existing skipped tests were already targeting the right layer, but two local harness issues were keeping them out of the active suite: the
ApiOptionstest double did not render a reasoning-effort control, and theSettingsView.unsaved-changesdialog mock behaved as though the dialog were always mounted. This change fixes those blockers, unskips the regression cases, and adds awebview-ui/AGENTS.mdfile that steers future work toward the component-test layer unless the real VS Code extension harness is genuinely required.User impact
No user-facing product behavior changes. Contributors and agents now get stronger, faster regression coverage in the
webview-uisuite, and the local guidance makes it clearer when a settings regression should stay in Vitest instead of being pushed into the slower VS Code e2e layer.