fix: upgrade isbinaryfile to 5.0.7#88
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between 43196f256ac8c68130673dcfb108c58735b3917c and 187a55f. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates ChangesDependency Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 check still pending after the review wait window.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
43196f2 to
187a55f
Compare
edelauna
left a comment
There was a problem hiding this comment.
Thank you for addressing this and referencing the upstream issue.
Related GitHub Issue
This PR addresses the same root cause as the following Roo Code issues (inherited bug, still present in Zoo Code):
RangeError: Invalid array lengthRoo Code Task Context (Optional)
N/A
Description
This PR upgrades the
isbinaryfiledependency from^5.0.2(resolving to buggy5.0.4) to^5.0.7to fix a crash when processing files containing multibyte UTF-8 characters (Chinese, Japanese, Korean, emoji, etc.).Problem
When Zoo Code processes a file whose UTF-8 multibyte sequence falls across the 512-byte buffer boundary used for binary detection, the extension crashes with:
Version history of
isbinaryfile5.0.4— Crashes on certain UTF-8 files ❌5.0.7— Comprehensive fix for both issues ✅Changes
pnpm-lock.yamlis updated accordingly (5.0.4→5.0.7).Test Procedure
RangeError: Invalid array length(see screenshot below).The fixture is also part of the upstream test suite to prevent regression.
Pre-Submission Checklist
5.0.4and verified the fix on5.0.7Screenshots / Videos
Crash reproduced on Zoo Code (with
isbinaryfile@5.0.4):Error:
RangeError: Invalid array lengthwhen reading a UTF-8 file with Chinese characters at the buffer boundary. The extension becomes unresponsive.After applying this PR (
isbinaryfile@5.0.7), the same file is processed without error. Verification can be reproduced via the test procedure above.Documentation Updates
Get in Touch
GitHub: @f14XuanLv
Discord: f14xuanlv
Summary by CodeRabbit