test(read-file): unskipping read-file tests

[edelauna]

Related GitHub Issue

Closes: #

Roo Code Task Context (Optional)

Description

This PR enables the read_file VS Code e2e smoke suite under aimock replay.

Key changes:

• Unskips the Roo Code read_file Tool suite and converts the tests away from brittle transcript internals like api_req_started.
• Adds deterministic read-file prompts and filenames so the suite can be replayed consistently.
• Adds curated aimock fixtures for the model's first turn, where it chooses the expected read_file tool calls.
• Adds read-file-specific programmatic replay fixtures for the follow-up model turn. These fixtures only return the canned completion after the actual read_file tool result contains stable expected substrings, so replay still validates the tool path instead of only asserting mocked final text.
• Keeps the global e2e runner change minimal: runTest.ts only registers the read-file fixture helper during replay mode; the suite-specific matching logic lives in src/fixtures/read-file.ts.

Reviewer notes:

• The follow-up fixtures intentionally use programmatic predicates because the JSON fixture format can match by prompt/tool call id, but cannot inspect the full tool result content.
• The missing-file replay predicate matches the actual Node/fs error shape (ENOENT, no such file or directory) while the final model-facing completion remains user-friendly.
• Generated OpenRouter recording files are not part of the PR; the committed fixture is the curated fixtures/read-file.json plus the focused programmatic matcher.

Test Procedure

Validated locally with:

pnpm --filter @roo-code/vscode-e2e check-types
pnpm --filter @roo-code/vscode-e2e test:run -- --file read-file.test.js

Result: 7 passing for the read-file e2e suite.

Environment notes from local runs:

• Background OpenRouter 404 No fixture matched messages appeared after task completion, but the targeted replay fixtures completed and the suite passed.

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A, test-only change.

Documentation Updates

• No documentation updates are required.
• Yes, documentation updates are required. (Please describe what needs to be updated or link to a PR in the docs repository).

Additional Notes

This PR intentionally focuses only on the read_file suite. Other skipped e2e suites can be enabled in follow-up PRs using the same pattern where replay needs to validate tool-result content.

Get in Touch

Summary by CodeRabbit

• Tests
  • Expanded E2E coverage for file-reading: simple, multiline, sliced (offset/limit), missing files, XML, multiple sequential reads, and large-file scenarios.
  • Added reusable fixtures to drive these scenarios and enabled the read-file test suite.
  • Standardized test inputs and shifted verification to assistant-visible responses for more robust, higher-level validation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e7a6d052-021e-4cb2-bc2c-0f68da4849fa

📥 Commits

Reviewing files that changed from the base of the PR and between 9f39044 and 653e227.

📒 Files selected for processing (4)

• apps/vscode-e2e/fixtures/read-file.json
• apps/vscode-e2e/src/fixtures/read-file.ts
• apps/vscode-e2e/src/runTest.ts
• apps/vscode-e2e/src/suite/tools/read-file.test.ts

✅ Files skipped from review due to trivial changes (1)

• apps/vscode-e2e/fixtures/read-file.json

🚧 Files skipped from review as they are similar to previous changes (2)

• apps/vscode-e2e/src/fixtures/read-file.ts
• apps/vscode-e2e/src/suite/tools/read-file.test.ts

---

📝 Walkthrough

Walkthrough

Adds read_file JSON fixtures and TypeScript helpers, registers them with the test mock server, and refactors the read-file e2e tests to use deterministic filenames and assert assistant completion text across seven scenarios.

Changes

read_file Fixture Infrastructure and Test Suite Migration

Layer / File(s)	Summary
Fixture data, types, helpers, and registration apps/vscode-e2e/fixtures/read-file.json, apps/vscode-e2e/src/fixtures/read-file.ts, apps/vscode-e2e/src/runTest.ts	Adds JSON fixtures for seven read_file scenarios; introduces TypeScript types and a type guard; implements predicates to match tool-call messages by tool_call_id; exports addReadFileResultFixtures and wires it into the test runner to register attempt_completion fixtures.
Test suite enablement and fixture-based assertions apps/vscode-e2e/src/suite/tools/read-file.test.ts	Enables the read-file suite, replaces dynamic filenames with deterministic workspace-relative paths, removes direct tool-result parsing from message handlers, tags prompts with READ_FILE_*_SMOKE, and updates assertions to verify assistant completion text for expected content patterns across simple, multiline, slice, missing, XML, multi-file, and large-file cases.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

A rabbit spies the test-run hum,
Fixtures sown for reads to come,
Deterministic paths take flight,
Assistant text now shows the light,
Hoppity mocks — the tests run right! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: unskipping (enabling) the read-file tests in the test suite.
Description check	✅ Passed	The description provides comprehensive details on key changes, implementation rationale, test validation, and design decisions, though the related GitHub Issue link is missing (placeholder only).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore-unkip-e2e-tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/vscode-e2e/src/fixtures/read-file.ts

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/vscode-e2e/src/suite/tools/read-file.test.ts

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/vscode-e2e/src/runTest.ts

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/vscode-e2e/fixtures/read-file.json`:
- Around line 4-105: Each of the seven turn-1 fixtures (the match objects for
userMessage values READ_FILE_SIMPLE_SMOKE, READ_FILE_MULTILINE_SMOKE,
READ_FILE_SLICE_SMOKE, READ_FILE_MISSING_SMOKE, READ_FILE_XML_SMOKE,
READ_FILE_MULTIPLE_SMOKE, READ_FILE_LARGE_SMOKE — e.g. the entries that return
toolCalls with ids like call_read_file_simple_001, call_read_file_multiline_001,
call_read_file_slice_001, call_read_file_missing_001, call_read_file_xml_001,
call_read_file_multiple_simple_001 / call_read_file_multiple_multiline_001,
call_read_file_large_001) must be pinned to turn 1 by adding "sequenceIndex": 0
into each match object; update each match JSON to include sequenceIndex: 0 at
the same level as "userMessage" so retries/replays won’t overmatch.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4507eb4f-a80d-47b0-a1b3-6f56dd3ceea3

📥 Commits

Reviewing files that changed from the base of the PR and between 6c5d4e1 and 9f39044.

📒 Files selected for processing (4)

• apps/vscode-e2e/fixtures/read-file.json
• apps/vscode-e2e/src/fixtures/read-file.ts
• apps/vscode-e2e/src/runTest.ts
• apps/vscode-e2e/src/suite/tools/read-file.test.ts

[taltas]

Nice