Skip to content

fix(e2e): stabilize flaky provider suite ordering and zai requestCapture race #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edelauna merged 1 commit into from
Jun 7, 2026
Merged

fix(e2e): stabilize flaky provider suite ordering and zai requestCapture race #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/vscode-e2e/src/suite/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,16 @@ export async function run() {
throw new Error(`No test files found matching criteria: ${process.env.TEST_FILE || "all tests"}`)
}

// Run provider suites last so their teardown (which may leave per-mode profile
// pins pointing at non-default providers) doesn't affect tool suites that start
// tasks in specific modes and expect the default openrouter config.
testFiles.sort((a, b) => {
const aIsProvider = a.includes("/providers/")
const bIsProvider = b.includes("/providers/")
if (aIsProvider === bIsProvider) return a.localeCompare(b)
return aIsProvider ? 1 : -1
})

testFiles.forEach((testFile) => mocha.addFile(path.resolve(cwd, testFile)))

return new Promise<void>((resolve, reject) =>
Expand Down
14 changes: 10 additions & 4 deletions apps/vscode-e2e/src/suite/providers/zai.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ suite("Z.ai GLM provider", function () {
})

await waitUntilCompleted({ api, taskId })
const capturedMaxTokens = requestCapture.maxTokens

const completionMessage = messages.find(
({ say, text }) => (say === "completion_result" || say === "text") && text?.trim() === "4",
Expand All @@ -228,10 +229,12 @@ suite("Z.ai GLM provider", function () {

// Verify max_tokens uses the restored default clamp (20% of context window)
// unless the user explicitly overrides it via modelMaxTokens.
// Snapshot immediately after waitUntilCompleted to avoid straggling async calls
// from this task overwriting requestCapture before the assertion runs.
assert.strictEqual(
requestCapture.maxTokens,
capturedMaxTokens,
40_000,
`max_tokens should default to the glm-5.1 clamp (40_000) but was ${requestCapture.maxTokens}`,
`max_tokens should default to the glm-5.1 clamp (40_000) but was ${capturedMaxTokens}`,
)
})

Expand Down Expand Up @@ -260,6 +263,7 @@ suite("Z.ai GLM provider", function () {
})

await waitUntilCompleted({ api, taskId })
const capturedMaxTokens = requestCapture.maxTokens

const completionMessage = messages.find(
({ say, text }) => (say === "completion_result" || say === "text") && text?.trim() === "4",
Expand All @@ -269,10 +273,12 @@ suite("Z.ai GLM provider", function () {

// Verify max_tokens uses the restored default clamp (20% of context window)
// unless the user explicitly overrides it via modelMaxTokens.
// Snapshot immediately after waitUntilCompleted to avoid straggling async calls
// from the prior test overwriting requestCapture before this assertion runs.
assert.strictEqual(
requestCapture.maxTokens,
capturedMaxTokens,
40_551,
`max_tokens should default to the glm-5-turbo clamp (40_551) but was ${requestCapture.maxTokens}`,
`max_tokens should default to the glm-5-turbo clamp (40_551) but was ${capturedMaxTokens}`,
)
})
})
Loading