[Chore] Use a single PR flow for extension releases#142
Conversation
roomote
Bot
added
the
roomote:auto-resolve-conflicts
|
2 issues outstanding. Action required. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![roomote[bot]](https://avatars.githubusercontent.com/in/2924042?s=60&v=4){kind=small}
| 11. Open a single release PR with the fully generated release state. | ||
|
|
||
| ```bash | ||
| git add CHANGELOG.md src/CHANGELOG.md src/package.json README.md |
There was a problem hiding this comment.
Step 8 says major/minor releases should include translation updates, but this staging command only adds the English files. Any updated locales/*/README.md or src/package.nls*.json files will be left out of the release PR, so following the documented flow can silently drop the translated content from the release.
| workflow_dispatch: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, ready_for_review] | ||
| paths: |
There was a problem hiding this comment.
This allowlist does not include the translation files that step 8 of the new release flow tells operators to update (locales/*/README.md, src/package.nls*.json, etc.). If a follow-up commit only contains those translation updates, validate-release will not rerun and the PR can merge with a stale green release check from an earlier commit.
edelauna
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
2 participants
What problem this solves
Resolves the extra handoff in the current extension release process where operators have to merge a release-prep PR and then wait for CI to create a second version-bump PR. That flow makes Roomote-operated releases more complex than they need to be and keeps old PR-creation automation in the critical path.
Why this change was made
This updates the repo command to generate the final version and changelog state on the release branch before opening the release PR. It also replaces the old PR-creating workflow with a read-only release validation workflow so the documented process and CI checks match the new single-PR release path.
User impact
Release operators can now prepare one release PR that already contains the generated version bump and changelog updates, merge it, and then tag
mainto publish. There is no user-facing product behavior change.