[Chore] Clean up skipped extension package tests#110
Merged
Conversation
Contributor
Author
|
No actionable issues found. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
reviewed
May 14, 2026
eb78686 to
38c8051
Compare
edelauna
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
Resolves stale skipped coverage in the extension-package tests around project MCP settings, Task request shaping, and retry handling. Those skips were masking current behavior and leaving a mix of obsolete expectations and still-important flows unverified.
Why this change was made
The MCP settings tests were updated to match the current file creation and translated error behavior, the Task coverage was rewritten at narrower and more stable seams, and the obsolete ContextProxy integration block was removed. The retry assertions now follow the current auto-approval and structured backoff flow instead of the legacy retry strings and flags.
User impact
No user-facing product behavior changes. CI and future test work get clearer signal from the extension-package suite, with fewer stale skips and coverage that matches the current implementation paths.