Skip to content

[Chore] Clean up skipped extension package tests#110

Merged
edelauna merged 4 commits into
mainfrom
chore/cleanup-extension-test-skips-1lsxtoxrwb1xk
May 15, 2026
Merged

[Chore] Clean up skipped extension package tests#110
edelauna merged 4 commits into
mainfrom
chore/cleanup-extension-test-skips-1lsxtoxrwb1xk

Conversation

@roomote

@roomote roomote Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Elliott de Launay. View the task or mention @roomote for follow-up asks.

What problem this solves

Resolves stale skipped coverage in the extension-package tests around project MCP settings, Task request shaping, and retry handling. Those skips were masking current behavior and leaving a mix of obsolete expectations and still-important flows unverified.

Why this change was made

The MCP settings tests were updated to match the current file creation and translated error behavior, the Task coverage was rewritten at narrower and more stable seams, and the obsolete ContextProxy integration block was removed. The retry assertions now follow the current auto-approval and structured backoff flow instead of the legacy retry strings and flags.

User impact

No user-facing product behavior changes. CI and future test work get clearer signal from the extension-package suite, with fewer stale skips and coverage that matches the current implementation paths.

@roomote roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 14, 2026
@roomote

roomote Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

No actionable issues found. See task

  • Task.spec.ts now calls buildCleanConversationHistory() / maybeRemoveImageBlocks() directly, so it no longer proves attemptApiRequest() applies those transforms before api.createMessage().
  • ClineProvider.spec.ts seeds currentWorkspacePath directly, so it no longer verifies that openProjectMcpSettings uses the real active workspace state.
  • CI is no longer pending: e2e-mock.
  • CI is no longer pending: knip.
  • CI is no longer pending: platform-unit-test (ubuntu-latest).
  • CI is no longer pending: platform-unit-test (windows-latest).

@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread src/core/task/__tests__/Task.spec.ts Outdated
Comment thread src/core/webview/__tests__/ClineProvider.spec.ts Outdated
Comment thread src/core/task/__tests__/Task.spec.ts Outdated
@edelauna edelauna force-pushed the chore/cleanup-extension-test-skips-1lsxtoxrwb1xk branch from eb78686 to 38c8051 Compare May 15, 2026 00:19
@edelauna edelauna marked this pull request as ready for review May 15, 2026 00:26
@edelauna edelauna merged commit 39342a7 into main May 15, 2026
15 checks passed
@edelauna edelauna deleted the chore/cleanup-extension-test-skips-1lsxtoxrwb1xk branch May 27, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants