Skip to content

[Fix] Settings and marketplace stay inaccessible after importing Roo Router settings#109

Merged
edelauna merged 5 commits into
mainfrom
fix/restore-settings-after-roo-import-1axl8x1dmr3tt
May 14, 2026
Merged

[Fix] Settings and marketplace stay inaccessible after importing Roo Router settings#109
edelauna merged 5 commits into
mainfrom
fix/restore-settings-after-roo-import-1axl8x1dmr3tt

Conversation

@roomote

@roomote roomote Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Elliott de Launay. View the task or mention @roomote for follow-up asks.

Related GitHub Issue

Closes: #

Description

Fixes the VS Code extension webview after importing legacy Roo Router settings. When import downgrades the selected profile into an unconfigured state, Zoo now routes the user into Providers settings from any gated tab instead of trapping the whole shell on the welcome screen, keeps Settings plus Marketplace available for recovery, keeps Chat plus History gated until setup is complete, and treats settingsImportedAt as a one-shot host event so later sidebar relaunches do not replay an old import redirect.

Regression coverage now spans the webview tab-state matrix across Chat, History, Settings, and Marketplace plus a focused import/export host test that proves the import timestamp is posted once during the import sync and then cleared.

Test Procedure

  • pnpm --dir src test core/config/__tests__/importExport.spec.ts
  • pnpm --dir webview-ui test --run src/__tests__/App.spec.tsx
  • pnpm --dir apps/web-roo-code test

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required. (Please describe what needs to be updated or link to a PR in the docs repository).

Additional Notes

  • No matching approved GitHub issue was found during this task, so the issue link still needs to be filled in before merge.
  • The workspace had an unrelated .tool-versions modification, and this PR intentionally leaves it out.

Get in Touch

Elliott de Launay via the linked Roomote task or @roomote for follow-up.

@roomote roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 14, 2026
@roomote

roomote Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

1 issue outstanding: platform-unit-test (windows-latest) is still pending after the 10-minute CI watch window. See task

  • History is no longer gated while setup is incomplete, so the title-bar History action can still clear and rehydrate task state through showTaskWithId.
  • platform-unit-test (windows-latest) was still pending after the 10-minute CI watch window.
  • The import redirect still only fires from the chat tab, so imports that arrive while another gated tab is selected can still leave the user stuck on WelcomeView instead of routing into Providers settings.

@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread webview-ui/src/App.tsx Outdated
edelauna
edelauna previously approved these changes May 14, 2026
Comment thread webview-ui/src/App.tsx
Comment thread webview-ui/src/__tests__/App.spec.tsx
@edelauna edelauna dismissed their stale review May 14, 2026 17:56

didnt mean to approve

@roomote

roomote Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the latest sidebar-lifecycle follow-up in 82d35cf0f.

  • importSettingsWithFeedback now clears provider.settingsImportedAt immediately after the import-driven postStateToWebview(), so the timestamp behaves as a one-shot host event instead of persisting across sidebar relaunches.
  • Added focused regression coverage in src/core/config/__tests__/importExport.spec.ts to prove the timestamp is posted once during the import sync and then cleared.
  • Refreshed the PR proof with screenshots showing the first downgraded import redirecting into Providers settings and a later sidebar relaunch staying on Welcome without replaying that redirect.

I did not find a new unresolved review thread to close from this follow-up. Current PR state is REVIEW_REQUIRED, and platform-unit-test is still running on both Ubuntu and Windows.

Comment thread webview-ui/src/App.tsx Outdated
Comment thread webview-ui/src/App.tsx Outdated
@edelauna edelauna marked this pull request as ready for review May 14, 2026 19:21
@edelauna edelauna merged commit 1cf5a3c into main May 14, 2026
15 checks passed
@edelauna edelauna deleted the fix/restore-settings-after-roo-import-1axl8x1dmr3tt branch May 27, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants