Skip to content

PREAPPS-9206 Resolve Base Path Handling – Upgrade preact-router #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damini-vashishtha wants to merge 1 commit into
base: master
Choose a base branch
from
+63 −124
Open

PREAPPS-9206 Resolve Base Path Handling – Upgrade preact-router #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 59 additions & 122 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"preact-context-provider": "^2.0.0-preactx.2",
"preact-i18n": "^2.4.0-preactx",
"preact-render-to-string": "^5.2.0",
"preact-router": "github:zimbra/preact-router#3.1.1_base_path_support",
"preact-router": "github:zimbra/preact-router#PREAPPS-9206",
Copy link
Copy Markdown
Member

@silentsakky silentsakky May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be temporary but we should use proper branch names when merging the changes to master
something like 4.1.2_base_path_support

"react-redux": "^8.0.5",
"recompose": "^0.30.0",
"redux-actions": "^3.0.3",
Expand Down
2 changes: 2 additions & 0 deletions src/shims/preact-router/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,7 @@ export const route = wrap('route');
export const Router = wrap('Router');
export const Route = wrap('Route');
export const Link = wrap('Link');
export const exec = wrap('exec');
export const useRouter = wrap('useRouter');

export default global.shims['preact-router'];
2 changes: 1 addition & 1 deletion src/shims/preact/compat/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ const wrap = warnOnMissingExport.bind(null, global.shims['preact/compat'], 'prea

export const Component = wrap('Component');
export const Fragment = wrap('Fragment');
export const StrictMode = wrap('StrictMode');
export const createContext = wrap('createContext');
export const createElement = wrap('createElement');
export const createRef = wrap('createRef');
export const Children = wrap('Children');
export const PureComponent = wrap('PureComponent');
export const StrictMode = wrap('StrictMode');
export const Suspense = wrap('Suspense');
export const SuspenseList = wrap('SuspenseList');
export const __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = wrap('__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED');
Expand Down