Skip to content

Release 1.1.0#1

Merged
Zhen-Bo merged 7 commits into
masterfrom
release/1.1.0
Mar 9, 2026
Merged

Release 1.1.0#1
Zhen-Bo merged 7 commits into
masterfrom
release/1.1.0

Conversation

@Zhen-Bo

@Zhen-Bo Zhen-Bo commented Mar 9, 2026

Copy link
Copy Markdown
Owner

Release v1.1.0

Fixes the badge regression introduced in comfyui_frontend_package 1.38.x, polishes badge appearance, and adds the q keyboard shortcut.


What's Changed

Bug Fixes

# Issue Fix
1 Badge count stuck at 0 until panel is manually opened Moved updateBadge() before the if (!gridEl) return guard — in ≥ 1.38.x the panel renders lazily, so gridEl is null until first open
2 Badge visually too large on the narrow sidebar CSS injection reduces size from 10 px / 16 px9 px / 14 px
3 Badge positioned too close to the icon Shifted to −7 px top-right; scoped to queue tab only via :has(.pi-history)

New Feature

q keyboard shortcut — Toggles the queue panel. Registered via the declarative commands / keybindings API; appears in Settings → Keybindings and respects input-focus the same way as the built-in w / n / m / a shortcuts.


Compatibility

Version
ComfyUI Frontend 1.33.1+ · tested up to 1.39.19
ComfyUI Core tested up to 0.16.4

CI

Added test.yml (vitest on every push / PR) and release.yml (tests → GitHub Release with changelog on semver tag), complementing the existing publish.yml (Comfy Registry).


How to Test

  1. Open ComfyUI with the panel closed → queue a prompt → confirm badge count increments
  2. Press q → confirm panel toggles; check Settings → Keybindings shows the entry
  3. Verify badge is smaller and positioned slightly higher-right than before

Zhen-Bo added 7 commits March 9, 2026 11:10
In comfyui_frontend_package >=1.38.x the sidebar panel switched from
eager to lazy rendering: render(el) is only called the first time the
user opens the panel, so gridEl is null until then.  The previous code
called updateBadge() only inside render(), after the `if (!gridEl)
return` guard, meaning the badge was never updated while the panel
remained closed.

Move updateBadge() to the top of render(), before the guard, so it
always runs regardless of whether the panel has been opened.  Remove
the two now-redundant calls at the end of each early-return path.
Register ComfyUI.QueueSidebar.Toggle command and bind it to q via the
declarative commands/keybindings API so the shortcut appears in the
user's Settings > Keybindings list and behaves identically to the
built-in w/n/m/a sidebar shortcuts.
Inject CSS to shrink .sidebar-icon-badge from the default 10px/16px to
9px/14px so the badge is less visually dominant on the narrow sidebar.
Override the default -top-1 -right-1 (-4px) position to -7px for the
queue tab badge only, using :has(.pi-history) to avoid affecting other
sidebar tab badges.
test.yml  — run vitest on every push/PR to master to guard the branch
release.yml — on semver tag: gate on tests, then create a GitHub
              Release with auto-generated changelog from git log

No zip artifact: this plugin is git-based (Manager / git clone),
so downloadable archives add no value.
publish.yml (Comfy Registry) is kept separate and unchanged.
@Zhen-Bo Zhen-Bo merged commit 8c95a3e into master Mar 9, 2026
1 check passed
@Zhen-Bo Zhen-Bo changed the title Release v1.1.0 Release 1.1.0 Mar 9, 2026
@Zhen-Bo Zhen-Bo deleted the release/1.1.0 branch March 9, 2026 03:21
@Zhen-Bo Zhen-Bo mentioned this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant