Remove all async support, make framework entirely sync-only#20
Open
Remove all async support, make framework entirely sync-only#20
Conversation
This removes the async dependency resolution system that was added in beta.8-beta.12. The framework is now purely synchronous. Changes: - Delete bevy/async_hooks.py - Rewrite hooks.py: remove async from HookManager.handle/filter - Rewrite find_results.py: remove __await__, get_async, make get() sync - Rewrite injections.py: remove call_using_async, is_async, make sync - Rewrite containers.py: make all injection methods sync, remove async branches - Delete 3 async test files and 11 async tests from test_bevy.py - Remove pytest-asyncio dependency from pyproject.toml - Remove async planning docs and example files - Update CLAUDE.md, api.md, usage-guide.md, feature-planning docs All 161 existing sync tests continue to pass. https://claude.ai/code/session_01AbGbMaZmnKSjsBMgxjGcDZ
The test workflow was using --cov flags but pytest-cov isn't a dependency, causing all CI checks to fail. Also adds an auto-merge workflow that merges PRs labeled "auto-merge" once all checks pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- pytest 6.x uses ast.Str which was removed in Python 3.14, causing collection failures on macOS/Windows runners - Matrix now matches pyproject.toml's python = "^3.12" constraint - Upgrade setup-python to v5 and cache to v4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the async dependency resolution system that was added in
beta.8-beta.12. The framework is now purely synchronous.
Changes:
All 161 existing sync tests continue to pass.
https://claude.ai/code/session_01AbGbMaZmnKSjsBMgxjGcDZ