Skip to content

NOISS: Move email address definitions to config#886

Open
kjporter wants to merge 8 commits intomainfrom
move-email-addr-to-config
Open

NOISS: Move email address definitions to config#886
kjporter wants to merge 8 commits intomainfrom
move-email-addr-to-config

Conversation

@kjporter
Copy link
Copy Markdown
Contributor

This PR will:

  • First PR in a series that moves ZTL-specific data to configs
  • Adds ARTCC config file (bias/defaults to ZTL)
  • Swaps hard-coded @ztlartcc.org email addresses with config() reference

@kjporter kjporter added the enhancement New feature or request label Mar 21, 2026
@kjporter kjporter marked this pull request as ready for review April 2, 2026 21:02
@kjporter kjporter requested a review from a team as a code owner April 2, 2026 21:02
@kjporter kjporter added tech debt and removed enhancement New feature or request labels Apr 2, 2026
Copy link
Copy Markdown
Member

@iccowan iccowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the .env.example with all the new environment variables added here

Comment thread resources/views/dashboard/controllers/profile.blade.php Outdated
Comment thread tests/Browser/PilotPassportChallengeTest.php
Comment thread app/Livewire/TaStatsMonthly.php Outdated
@kjporter
Copy link
Copy Markdown
Contributor Author

kjporter commented Apr 6, 2026

We should also update the .env.example with all the new environment variables added here

Good suggestion - done.

Copy link
Copy Markdown
Member

@iccowan iccowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

public function viewStore() {
$merch_items = Merch::get();
$merch_email = Config::get('ztl.merch_store_email');
$merch_email = Config::get('artcc.merch_store_email');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be artcc.email_merch_store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants