Get latest#48
Merged
Merged
Conversation
Resolves issue where closing the success dialog too quickly would prevent the device from reconnecting with new communication settings. The problem was that ReconnectAfterCommunicationChange() returned immediately after calling StartConnection() and AddDevice(), which kick off background connection processes. If the dialog closed and the async chain completed too quickly, it would interrupt the connection before it could establish. Changes: - Add WaitUntilDeviceIsOnline() method that polls device status every 100ms with 10-second timeout - Update ReconnectAfterCommunicationChange() to wait for connection to establish before returning - Remove arbitrary 500ms delay from ManageViewModel as proper wait is now in service layer - Add 4 comprehensive tests validating the new wait behavior and settings preservation - Add test for standard Reconnect() method for completeness The reconnection now completes successfully regardless of dialog timing. All 83 tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use OSDP.Net MessageSpy for packet parsing with secure channel decryption - Add SecurityKey property to IDeviceManagementService for tracing access - Fix packet details display to show hex values instead of "System.Byte[]" - Only clear trace on disconnect, preserving negotiation packets - Add secure channel indicator badge to Monitor page 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Show Clear Text (red) when not using secure channel - Show Encrypted - Default Key (red) when using default security key - Show Encrypted (green) when using custom security key - Add UsesDefaultSecurityKey property to ViewModels - Add localization note to CLAUDE.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
New Crowdin updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.