Update changes#46
Merged
Merged
Conversation
Release 3.0.12
Implemented INotifyPropertyChanged and theme change event handling to ensure the Z-bit logo in InfoPage updates its color scheme immediately when Windows theme changes, without requiring application restart. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
When a connection has problems (InvalidSecurityKey, timeout, etc.), the status is set to Error. This update ensures that Error status is treated as connected, allowing users to disconnect from problem connections. - Show Disconnect button when status is Connected or Error - Hide Connect button when status is Connected or Error - Hide Start Discovery button when status is Connected or Error 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
After clicking Start Discovery then Cancel, the button now correctly returns to "Start Discovery" instead of showing "Disconnect". Removed Error status from connected state check since canceling discovery doesn't mean you're connected to a device. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Use TrySetResult instead of SetResult to prevent InvalidOperationException when dialog buttons are clicked multiple times. Also fixed closure issue by directly capturing dialogWindow instead of using intermediate null variable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Devices discovered with secure channel now connect properly. Previously, the secure channel parameter was hardcoded to false, causing connection failures. Additionally, moving the _isDiscovering flag to the finally block prevents race conditions where the ConnectionStatusChanged event handler would interfere with post-discovery connections. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Ensures Connect page displays updated communication settings when changed from Manage page. Previously, communication settings would update on the device but the Connect page UI would not reflect the changes. Additionally fixes device reconnection failing when baud rate is changed. The device switches to new communication parameters immediately after responding to the SetCommunication command, so the old connection cannot communicate with it. Added ReconnectAfterCommunicationChange method that skips waiting for the device to go offline on the old connection, eliminating the 5-second timeout and enabling successful reconnection on new settings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Moved all button visibility logic from ConnectPage (View) to ConnectViewModel for reusability across different UI frameworks. Fixed secure channel default behavior to prevent auto-enabling encryption after discovery. Changes: - Move ConnectionTypes and button visibility logic to ConnectViewModel - Add 5 boolean properties for button visibility with proper state handling - Fix secure channel to default to disabled (unchecked) - Fix discovery to not auto-enable secure channel, respecting user preference - Add Discovered state to Disconnect button visibility for cancellation - Fix cancelled discovery to show Start Discovery button instead of no buttons - Add comprehensive unit tests (17 tests for button visibility) - Update documentation with all fixed bugs All 77 tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The Monitor page was not showing content when an invalid security key error occurred, while the Manage page was correctly showing its content. Changes: - Updated MonitorViewModel to handle InvalidSecurityKey error state - Added switch statement to properly set StatusLevel.Error for invalid key - Updated MonitorPage.xaml visibility binding to include "Error" state - Added test case for InvalidSecurityKey error handling Now both Manage and Monitor pages are consistently active during error state. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Users can now access the Monitor page even after disconnecting, allowing them to review trace history from previous connections. Changes: - Removed "Device not connected" warning that blocked page access - Removed visibility constraint that only showed content when Connected/Error - Monitor page now accessible in all connection states This improves UX by allowing users to review captured trace data after they disconnect from a device. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Track commands sent, replies received, polls, and NAK counts - Calculate line quality percentage (accounts for 2 in-flight commands) - Display statistics panel with prominent line quality indicator - Reset all statistics on reconnection - Add localized resource strings for statistics labels 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Documents 4 recent commits for MAUI implementation reference: - Disconnect button visibility fix for invalid security key - Monitor page error state handling - Monitor page access after disconnect - Packet statistics with line quality percentage Includes: - Detailed change descriptions for each commit - Core ViewModel changes (already in shared library) - Windows XAML implementation examples - MAUI implementation guidelines with example code - Testing scenarios and checklist - Migration priorities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.