Release 3.0.11#40
Merged
Merged
Conversation
- Test connection functionality with various configurations - Test device discovery process - Test event handling and subscription - Test helper methods via reflection - Include proper teardown for test cleanup 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Removed the DeviceManagementService refactoring item since it has been completed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…nt-service-tests Feature/device management service tests
- Extract large switch statement in DiscoverDevice method - Split ScanSerialPorts method into smaller focused methods - Simplify nested logic in ConnectDevice - Add unit tests for event handling - Fix BitArray ambiguity in DeviceManagementServiceTests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…t-viewmodel Feature/refactor connect viewmodel
- Extract special handling for ResetCypressDeviceAction into separate method - Extract SetCommunicationAction handling into separate method - Add unit tests for ManageViewModel - Make IdentityLookup properties virtual for better testability - Improve code organization and error handling
- Create proper test implementation of IdentityLookup - Fix DeviceIdentification constructor issues using ParseData factory method - Update CLAUDE.md to mark improved test coverage as completed 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Create MonitoringAction class to replace MonitorCardReads and MonitorKeypadReads - Add MonitoringType enum to distinguish between different monitoring types - Update ManageViewModel to use the new consolidated class - Add extension methods for easier type checking - Add comprehensive unit tests - Update CLAUDE.md to mark this refactoring as completed 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…itoring-actions Consolidate monitoring actions into a unified class
- Remove duplicated setup code in ConnectViewModelTests.cs - Add helper methods for common test operations - Add unit tests for MonitorViewModel - Update CLAUDE.md to mark test improvements as complete 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Improve test quality and coverage
1. Standardize error handling approach: - Added ShowExceptionDialog method to IDialogService - Implemented WindowsDialogService.ShowExceptionDialog - Created ExceptionHelper utility class with standardized try/catch patterns - Updated ManageViewModel to use the new error handling utilities 2. Reduce ViewModels coupling to DeviceManagementService: - Added IDeviceStateService interface as an abstraction layer - Implemented DeviceStateService that forwards events from DeviceManagementService 3. Fixed naming inconsistencies in MonitoringAction 4. Updated tests to work with the new error handling approach 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…oring Complete remaining refactoring opportunities
Default to Not Ready status when no USB Serial Port is detected
New Crowdin updates
New Crowdin updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.