Fix image load issue with digest only#23
Merged
Conversation
added 2 commits
May 11, 2026 08:26
Two changes in the post-import alias step:
1. The alias loop walked every new row from `ctr image list`,
including the bare `sha256:<hex>` config-digest row that ctr
writes alongside the canonical ref. stripTag turned that into
the literal "sha256", and the synthesized alias became
"sha256@sha256:<digest>" -- a garbage entry that kubelet's
checkpoint-image check on containerd v2 normalizes to
"docker.io/library/sha256@..." (not found), leaving the pod
stuck in CreateContainerError.
2. Digest-only input refs ("<repo>@<digest>") landed in the image
store without any tag-form alias, hitting the same kubelet
lookup failure. Loader now synthesizes a "<repo>:latest@<digest>"
alias so crictl and kubelet resolve them. Matches the manual
`ctr image tag --force` workaround checkit's appliance-init.sh
has been carrying for the holdout images (minio-deduplication,
solsson/kafka:native-cli).
Decision lives in aliasFor(ref, digest), unit-tested in
TestAliasFor. Summary log filters the config-digest row too, so
operators no longer see misleading "imported sha256:..." lines.
Refs specs/y-cluster/ISSUE_IMAGES_LOAD_MANGLES_CONFIG_DIGEST_REFS.md
solsson
pushed a commit
to Yolean/ystack
that referenced
this pull request
May 12, 2026
Bumps host bin (bin/y-bin.runner.yaml) and the in-cluster y-kustomize Deployment image across four consecutive y-cluster releases: - v0.4.2: `images load` accepts remote refs (Yolean/y-cluster#22) - v0.4.3: fix `images load` for digest-only refs (Yolean/y-cluster#23) - v0.4.4: `images list --context=<ctx>` subcommand (Yolean/y-cluster#24) and tunable Gateway API resource requests (Yolean/y-cluster#25) - v0.4.5: re-fix digest-only image tagging and gateway resource requests (Yolean/y-cluster#26) Image digest verified via `crane digest ghcr.io/yolean/y-cluster:v0.4.5`. sha256 sums copied from v0.4.5's checksums.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.