feat: parse multi-timestamp lyrics & other improvements#5

Open

MSOB7YY wants to merge 27 commits intoYivan000:masterfrom

MSOB7YY commented Aug 15, 2024

This PR contains the following:

core: remove ^..*$ pattern from Lrc.isValid()
- this was causing the vm to hang while checking some lyrics
perf: use StringBuffer for formatting lrc (in Lrc.format())
- instead of recreating new String on each concat
feat: parse multi-timestamp lyrics
- lyrics lines like [00:29.02][00:44.02]Line 3 lyrics will get parsed properly, and sorted if needed
some refactor & adding test

thanks for this awesome package btw, i don't mind if this pr didn't get merged, just thought it might be helpful.

pls note i have only tested with normal synced lyrics. the pr might need more tests with other types like extended & enhanced

MSOB7YY added 27 commits

August 13, 2024 23:35


          core: remove ^..*$ pattern from Lrc.isValid()

42147f2

this fixes the heavy matching that could be caused, preventing vm from freezing


          perf: use StringBuffer for formatting lrc

2131d62


          feat: parse multi-timestamp lyrics

57389fa


          core: add tests

61f2b6d


          feat: parse multi language lines separated by ;   |

d95622b


          chore: remove ; as multi-lang splitter

3a9fa81

and improve by ensuring more characters left after the separator


          core: improve regex matching

94f9538


          chore: losen 'isValid' matching

596b633


          feat: add Lrc.cleanPlainLyrics()

dc4a21f


          fix: properly sort if lrc has another language in the end of the file

e0e6779


          core: improve enhanced lyrics extraction & optimize code

e31ae5c


          chore: improve isValid regex

3b34a63


          code: project restructure

d7fec07


          chore: improve enhanced lyrics extraction v2

63b7b09


          feat: parse ttml lyrics (xml files)

d794a07


          test: add tests

212a400


          fix: lines sorting for multi lang lyrics

a3c9358


          core: improve ttml parser to support normal format

7fc4436


          chore: support word synced lyrics that has no trailing timestamp

83f04af


          fix: disable multi-lingual for double spaces when line is word synced

dadca50


          fix: ensure persontext has :

f3a2926


          chore: support utf16 encoded lrc files

0fd4d8e


          feat: Lrc.forUiDisplay()

f12f60f


          feat: optional romanize for Lrc.forUiDisplay()

9e82620

disabled by default, doesn't romanize all kanji


          chore: use List<int> for highlightTimestampsMap in `Lrc.forUiDisp…

fbc2806

…lay`


          fix: wrong timestamp for custom added empty line in Lrc.forUiDisplay()


          fix: ignore space after lrc duration

039461a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet