Conversation
Api based webapp
Styled header and footer
Comment popup windows
…ipt-capstone-project into comment-popup-windows
Comment popup windows
JavaScript capstone project
rotimiazeez
left a comment
rotimiazeez
left a comment
There was a problem hiding this comment.
Hi TEAM 👍🏽,
Good job so far!
To Highlight 👇🏽
- Good UI 👍🏽
- No Linter error ✔️
- Good PR description 👍🏽
- Good commit message(s) 😉
- Descriptive README 📖
You still need to work on some issues to prepare your project for the final evaluation, but you are almost there!
Suggested changes
- As a team of 3, you should have a
Reservationpopup that loads. The web app should retrieve data from the selected API and show details about the selected item. And likewise, retrieve data from the Involvement API to show the item reservations. - Also, you should have a reserve button, in which when a user clicks on the "Reserve" button, the data should be recorded in the Involvement API and the screen updated as a result.
- Please ensure counter functions are covered with unit tests using Jest. Make sure that you have tests for all edge cases.
Check the comments under the review.
Please feel free to use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend considering them as they can improve your code._
You can also consider the following:
- Have a fair workload distribution across the team.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag (@rotimiazeez) me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid, unless it is requested otherwise.
|
|
||
| This project is [MIT](./LICENSE) licensed. | ||
|
|
There was a problem hiding this comment.
- The MIT link provided is broken 😢, kindly provide a valid license link 👍🏽.
There was a problem hiding this comment.
The License link is fixed
src/Modules/userApi.js
Outdated
| const addLike = async (id) => { | ||
| const body = JSON.stringify({ item_id: id }); | ||
| const headers = { "Content-type": "application/json; charset=UTF-8" }; | ||
| /* eslint-disable */ | ||
|
|
There was a problem hiding this comment.
- Please ensure users can like a meal. Currently I'm unable to, kindly fix this 👍🏽
| if (e.target.classList.contains('comment-btn')) { | ||
| const mealItem = e.target.parentElement.parentElement; | ||
| fetch( | ||
| `https://www.themealdb.com/api/json/v1/1/categories.php?i=${mealItem.dataset.id}`, | ||
| ) | ||
| .then((response) => response.json()) | ||
| .then((data) => mealsFunction(data.categories)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Just so you know, when I try to get more information about a meal, I keep getting information about the first food on the list. Please take a look at this; users should be able to see the information on the specific meal they chose. 👍🏽
There was a problem hiding this comment.
The License link is fixed
correct based on review
4 participants
we should build these interfaces:
The home page.
The comments popup.
we should follow the layout of the wireframes provided. You should personalize the rest of the design including colors, typographies, spacings, etc.
Home page
When the page loads, the webapp retrieves data from:
Remember that your page should make only 2 requests:
When the user clicks on the Like button of an item, the interaction is recorded in the Involvement API and the screen is updated.
When the user clicks on the "Comments" button, the Comments popup appears.
Home page header and navigation similar to the given mockup.
Home page footer similar to the given mockup.
Comments popup
Counters
We have counters in all the interfaces that show:
The number of items (home).
The number of comments (comments popup).