Skip to content

fix: [2.0.0] 2μ°¨ QA [2]#198

Merged
ShapeKim98 merged 21 commits intodevelopfrom
fix/#196-qa2-shapekim98
Jul 16, 2025
Merged

fix: [2.0.0] 2μ°¨ QA [2]#198
ShapeKim98 merged 21 commits intodevelopfrom
fix/#196-qa2-shapekim98

Conversation

@ShapeKim98
Copy link
Contributor

#οΈβƒ£μ—°κ΄€λœ 이슈

#196

πŸ“μž‘μ—… λ‚΄μš©

이번 PRμ—μ„œ μž‘μ—…ν•œ λ‚΄μš©μ„ κ°„λž΅νžˆ μ„€λͺ…ν•΄μ£Όμ„Έμš”(이미지 첨뢀 κ°€λŠ₯)

포킷 μΆ”κ°€/μˆ˜μ •

  • μ „μ²΄κ³΅κ°œ, 포킷 ν‚€μ›Œλ“œ 미선택 μ‹œ λ²„νŠΌ λΉ„ν™œμ„±ν™” 처리, ν˜„μž¬λŠ” λ²„νŠΌ λˆŒλ €μ„ λ•Œ μ—λŸ¬μ²˜λ¦¬κ°€ λ˜λŠ”λ° 둜직 μˆ˜μ •
  • λ―ΈλΆ„λ₯˜ 링크 κΈ°λ³Έ 사진 적용
  • ν‚€λ³΄λ“œκ°€ μ˜¬λΌμ™”μ„ λ•Œ λΉˆκ³³μ΄λ‚˜ λ‹€λ₯Έ μ»΄ν¬λ„ŒνŠΈ λˆŒλ €μ„ λ•Œ ν‚€λ³΄λ“œ λ‚΄λ €κ°€κ²Œ μˆ˜μ •

포킷 상세

  • ν•„ν„° 닀쀑 선택 제거
  • ν•„ν„° λ²„νŠΌ μ•„μ΄μ½˜ μΆ”κ°€

λ§ν¬μΆ”μ²œ

  • ν‚€μ›Œλ“œ 선택 둜직 μˆ˜μ •

링크 λͺ©λ‘

  • 즐겨찾기/μ•ˆμ½μŒ λˆŒλ €μ„ λ•Œ ν•˜λ‹¨μ—μ„œ μ˜¬λΌμ˜€λŠ” μ• λ‹ˆλ©”μ΄μ…˜ μˆ˜μ • ν•„μš”

검색

  • 졜근 검색어 ν‘œμ‹œ μ—¬λΆ€ λΆ„κΈ° λ³€κ²½
  • 검색 ν•„ν„° ν™œμ„±ν™” λ²„νŠΌ 변경사항 반영
  • μΊ˜λ¦°λ” 였늘 λ‚ μ§œ 이후 λ²„νŠΌ λΉ„ν™œμ„±ν™”

μ„€μ •

  • ν”„λ‘œν•„ μˆ˜μ • μ‹œ λ‹‰λ„€μž„ ν…μŠ€νŠΈν•„λ“œ λˆŒλ €μ„ λ•Œ 'μ€‘λ³΅λœ λ‹‰λ„€μž„' μ—λŸ¬ μˆ˜μ •
  • ν”Œλ ˆμ΄μŠ€ν™€λ” μˆ˜μ •: λ‚΄μš©μ„ μž…λ ₯ν•΄μ£Όμ„Έμš” -> λ‹‰λ„€μž„μ„ μž…λ ₯ν•΄μ£Όμ„Έμš”

λ―ΈλΆ„λ₯˜ > νŽΈμ§‘ν•˜κΈ° μ‹œνŠΈ

  • disable μˆ˜μ •

ν¬ν‚·λ°”ν…€λ²„νŠΌ

  • κ·ΈλΌλ””μ–ΈνŠΈ λ°°κ²½ 적용
  • μ„ μ–Έν˜• ν”„λ‘œκ·Έλž˜λ° 일뢀 적용

PokitCaution

  • empty 이미지 λ³€κ²½
  • μ»΄ν¬λ„ŒνŠΈ μ—¬λ°± 변경사항 반영

μŠ€ν¬λ¦°μƒ· (선택)

πŸ’¬λ¦¬λ·° μš”κ΅¬μ‚¬ν•­(선택)

리뷰어가 νŠΉλ³„νžˆ λ΄μ£Όμ—ˆμœΌλ©΄ ν•˜λŠ” 뢀뢄이 μžˆλ‹€λ©΄ μž‘μ„±ν•΄μ£Όμ„Έμš”

μ»΄ν¬λ„ŒνŠΈ λ‹¨μœ„μ˜ 뷰에 μ„ μ–Έν˜• ν”„λ‘œκ·Έλž˜λ°μ„ 점차 λ„μž…ν•˜κ³ μž ν•©λ‹ˆλ‹€.

  • κΈ°μ‘΄ λ””μžμΈ μ‹œμŠ€ν…œ μ»΄ν¬λ„ŒνŠΈ ꡬ성은 μƒμ„±μž μ£Όμž…μ— μ˜μ‘΄ν•˜κΈ° λ•Œλ¬Έμ—, μ»΄ν¬λ„ŒνŠΈμ˜ λ””μžμΈ ꡬ성이 λ³΅μž‘ν•΄μ§€κ³ , λ‹€μ–‘ν•΄μ§ˆ 수둝 뷰의 μƒμ„±μžκ°€ κΈΈμ–΄μ§€κ³  가독성이 μ•ˆμ’‹μ•„ μ§€λŠ” 문제점이 μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
    λ˜ν•œ, 예λ₯Ό λ“€μ–΄ PokitBottomButton 같은 κ²½μš°μ—λŠ” 상황에 따라 ν‚€λ³΄λ“œ ν‘œμ‹œ 여뢀에 λ”°λ₯Έ ν•˜λ‹¨ νŒ¨λ”© 쑰절 둜직이 ν•„μš”ν•œλ°, 이λ₯Ό μ„ νƒμ μœΌλ‘œ μž¬μ‚¬μš©ν•˜κΈ°μ— ν•œκ³„κ°€ μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
// μƒμ„±μž μ£Όμž…μ΄ λ³΅μž‘ν•΄μ§
PokitIconButton(
    .icon(.edit),
    state: .default(.secondary),
    size: .small,
    shape: .round,
    action: { send(.관심사_νŽΈμ§‘_λ²„νŠΌ_λˆŒλ €μ„λ•Œ) }
)

PokitBottomButton(
    "μ €μž₯ν•˜κΈ°",
    state: isDisable ? .disable : .filled(.primary),
    isLoading: $store.saveIsLoading,
    action: { send(.μ €μž₯_λ²„νŠΌ_λˆŒλ €μ„λ•Œ) }
)
.padding(.horizontal, 20)
.pokitMaxWidth()
// ν•„μš”ν•œ λ·°λ§ˆλ‹€, ν•΄λ‹Ή λͺ¨λ””νŒŒμ΄μ–΄λ₯Ό 맀번 μ„ μ–Έν•΄μ€˜μ•Όν•¨
.padding(.bottom, store.isKeyboardVisible ? -26 : 0)
.padding(.bottom, 36)
  • μ΄λŸ¬ν•œ λ¬Έμ œμ μ„ κ°œμ„ ν•˜κΈ° μœ„ν•΄, μ»΄ν¬λ„ŒνŠΈ λ‹¨μœ„μ˜ 뷰에 μ„ μ–Έν˜• ν”„λ‘œκ·Έλž˜λ°μ„ 점차 λ„μž…ν•  μƒκ°μž…λ‹ˆλ‹€. μˆœμˆ˜ν•¨μˆ˜λ₯Ό ν†΅ν•œ 자기 μžμ‹ μ„ μƒˆλ‘œ μƒμ„±ν•˜λŠ” λ°©μ‹μœΌλ‘œ μ„ μ–Έμ μœΌλ‘œ κ΅¬μ„±ν–ˆμŠ΅λ‹ˆλ‹€.
public func keyboardAnchor(_ isKeyboardVisible: Bool) -> Self {
    PokitBottomButton(
        self.labelText,
        state: self.state,
        isLoading: self.$isLoading,
        isGradient: self.isGradient,
        isKeyboardVisible: isKeyboardVisible,
        action: self.action
    )
}

public func gradientBackground() -> Self {
    PokitBottomButton(
        self.labelText,
        state: self.state,
        isLoading: self.$isLoading,
        isGradient: true,
        isKeyboardVisible: self.isKeyboardVisible,
        action: self.action
    )
}

public func loading(_ isLoading: Binding<Bool>) -> Self {
    PokitBottomButton(
        self.labelText,
        state: self.state,
        isLoading: isLoading,
        isGradient: self.isGradient,
        isKeyboardVisible: self.isKeyboardVisible,
        action: self.action
    )
}
  • ν”„λ‘œμ νŠΈκ°€ κ·Έλ™μ•ˆ 많이 컀지기도 ν–ˆκ³ , μ»΄ν¬λ„ŒνŠΈλ„ 많기 λ•Œλ¬Έμ—.. μ‹œκ°„μ΄ λ‚ λ•Œλ§ˆλ‹€ 점차 λ„μž…ν•˜κ² μŠ΅λ‹ˆλ‹€...(미리 잘 ν–ˆμ–΄μ•Ό ν–ˆλŠ”λ°..)

close 이슈번호

ShapeKim98 added 18 commits July 1, 2025 13:14
@ShapeKim98 ShapeKim98 requested a review from stealmh July 14, 2025 12:39
@ShapeKim98 ShapeKim98 self-assigned this Jul 14, 2025
@ShapeKim98 ShapeKim98 added Feat κΈ°λŠ₯κ΅¬ν˜„ Design 🎨 λ””μžμΈ μž‘μ—… Fix κΈ°λŠ₯ μˆ˜μ • Bug πŸ”« ν˜„μž¬ 발견된 버그λ₯Ό μˆ˜μ •ν•˜κΈ° μœ„ν•¨ labels Jul 14, 2025
Copy link
Member

@stealmh stealmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!
맀번 λ‹¬μ•„μ£ΌλŠ”κ²Œ μ‹ κ²½μ“°μ˜€λŠ”λ°..γ… γ…  μ•žμœΌλ‘œ μ–΄λ–»κ²Œ λ„μž…λ  μ§€ κΈ°λŒ€λ©λ‹ˆλ‹€

고생 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€~!

@ShapeKim98 ShapeKim98 merged commit b08f9af into develop Jul 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug πŸ”« ν˜„μž¬ 발견된 버그λ₯Ό μˆ˜μ •ν•˜κΈ° μœ„ν•¨ Design 🎨 λ””μžμΈ μž‘μ—… Feat κΈ°λŠ₯κ΅¬ν˜„ Fix κΈ°λŠ₯ μˆ˜μ •

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants