feat: [2.0.0] 버전 업데이트에 따른 기능 추가 및 수정(링크 추천 API)#191
Merged
Conversation
Closed
3 tasks
stealmh
approved these changes
Mar 4, 2025
Member
stealmh
left a comment
There was a problem hiding this comment.
LGTM! 고생많으셨습니다~~ 시트관련해서 말씀하신대로 정리할 방법을 좀 찾아봐야겠네요
9c8c331 to
e7cfe50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
RecommendFeature모킹 제거RecommendKeywordBottomSheet구현스크린샷 (선택)
💬리뷰 요구사항(선택)
RecommendKeywordBottomSheet를 새로 추가하였습니다.PokitKeywordBottomSheet를 재활용 해보려 했는데, 실패했습니다.일단 유저 관심사 목록 조회 api의 스키마와, 포킷 키워드 스키마가 다르기도 했고,
PokitKeywordBottomSheet은 키워드 하나만 선택하는 로직인 것에 비해,RecommendKeywordBottomSheet는 최대 3개의 키워드를 선택할 수 있는 로직이라,, ui만 똑같지 사실상 재활용이 불가능 했습니다.언젠간 통합을 해야 할 것 같습니다.
신고하기 플로우를 임의로 약간 바꿨습니다.
close #187