feat: [2.0.0] 버전 업데이트에 따른 기능 추가 및 수정(링크 추천)#185
Merged
ShapeKim98 merged 23 commits intodevelopfrom Feb 4, 2025
Merged
Conversation
Member
stealmh
reviewed
Jan 30, 2025
Comment on lines
+143
to
+150
| Scope(state: \.recommend, action: \.recommend) { | ||
| withDependencies { | ||
| $0[UserClient.self] = .testValue | ||
| $0[ContentClient.self] = .testValue | ||
| } operation: { | ||
| RecommendFeature() | ||
| } | ||
| } |
stealmh
reviewed
Jan 30, 2025
Comment on lines
214
to
221
| return .run { [ | ||
| pageableRequest = BasePageableRequest( | ||
| page: state.domain.pageable.page, | ||
| size: state.domain.pageable.size, | ||
| sort: state.domain.pageable.sort | ||
| ), | ||
| keyword = state.selectedInterest?.description | ||
| ] send in |
Member
There was a problem hiding this comment.
요기만 캡쳐 전에 모델링 하던가 effect 내부에서 guard문 쓰는 식으로 고치면 가독성이 더 좋을 것 같읍니다
keyword처럼 한줄로 써지는거면 상관없는데 page모델이 좀 길어서 읽기불편한듯
Closed
3 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
FeatureRecommend피쳐 타겟 생성FeatureRemind피쳐 타겟 제거PokitIconButtonopacity상태 추가스크린샷 (선택)
💬리뷰 요구사항(선택)
링크 추천 기능을 추가하였습니다.
FeatureRecommend라는 이름으로 타겟을 추가하였습니다.FeatureRemind타겟 및 파일들을 제거하였습니다.TCA되게 오랜만이라.. 잘못됐거나 부족한거 있으면 바로 말씀해주세여...ㅎㅎ유저 관심사 목록 및 추천 컨텐츠 api를 작성하였습니다.
BaseContentItem에keyword프로퍼티가 추가되었습니다. 일단은 옵셔널로 해놨는데, 최근에 모든 api에 담겨져 오는거 같아서 api연동해보고 논옵셔널로 바꾸든지 하겠습니다.RecommedFeature에 필요한 api들은 모킹 상태입니다. 참고해주세요. 다음 작업 때 연동해보도록 하겠습니다.신고하기 및 관심사 수정 기능은 아직 구현하지 않았습니다.
PokitFlowLayout을 수정하였습니다.PokitIconButtonopacity상태 추가PokitIconButton변경사항 반영입니다.그 저희 이슈 관리 체계가 살짝 바뀐거 같아서 가이드 해주시면 따라가겠습니다 ㅎㅎ
close 이슈번호