Merged
Conversation
auphelia
approved these changes
Mar 20, 2025
Collaborator
There was a problem hiding this comment.
Thank you, @fpjentzsch!
That looks great :)
@penrosed , I have verified that the build flow goes through and I have check the throughput on the board using the driver.py. I also picked it up in the Jupyter Notebook and verified that the accuracy is the same.
penrosed
approved these changes
Mar 24, 2025
Collaborator
penrosed
left a comment
penrosed
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the optimisations :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should reach 97181 FPS instead of 1877 FPS.