fix: always show variant selector when model supports reasoning effort (fixes #742)#794
Open
MrRealORG wants to merge 1 commit into
Open
fix: always show variant selector when model supports reasoning effort (fixes #742)#794MrRealORG wants to merge 1 commit into
MrRealORG wants to merge 1 commit into
Conversation
fixes XiaomiMiMo#742) When a model with reasoning effort variants (e.g. mimo-v2.5-pro) is selected from the 'Recent' group in /model, the variant selector was skipped because the current variant was already valid. This made it impossible to change reasoning effort without manually editing the config file. The previous logic checked if the current variant was 'default' or already in the variant list, and if so, skipped the selector. This was intended to avoid the selector when switching to a model that doesn't need variant selection, but it also prevented users from changing their variant when re-selecting the same model. Fix: always show the variant selector when the model has available variants, regardless of the current selection. The 'Default' option in the variant selector allows users to keep their current setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #742. When selecting a model with reasoning effort variants from the Recent group in /model, the variant selector was skipped because the current variant was already valid. Remove the early-return condition and always show the variant selector when the model has available variants.