fix: add structured logging to frecency and stash file IO failures#785
Open
MrRealORG wants to merge 1 commit into
Open
fix: add structured logging to frecency and stash file IO failures#785MrRealORG wants to merge 1 commit into
MrRealORG wants to merge 1 commit into
Conversation
File writes in frecency.tsx (4 sites) and stash.tsx (5 sites) silently
swallowed errors via .catch(() => {}). On read-only filesystems,
permission errors, or full disks, these failures were completely invisible.
Now logs at debug level so operators can diagnose IO issues without
noise. The toast deduplication (PR XiaomiMiMo#776) allows safely upgrading
these to user-visible toasts in the future if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9
.catch(() => {})calls infrecency.tsxandstash.tsxsilently swallowed file IO errors. On read-only filesystems, permission errors, or full disks, these failures were completely invisible to both users and operators.Now logs at debug level so operators can diagnose IO issues. The toast deduplication added in PR #776 enables safely upgrading these to user-visible toasts in the future.