(ignore this) Cutscene code deduplication WIP#3221
Draft
binary1230 wants to merge 22 commits into
Draft
Conversation
- no code changes, comments only
binary1230
changed the title
- missed CSA1_V_OVL_EXPORT
- need to do 2ndhalf of PSP and HD specifics next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Apologies for any spam, if this PR is blowing up anyone's inbox, feel free to close it. Please ignore it for now)
I was attempting to de-duplicate various code in the cutscene handlers, and before continuing wanted to run this against the CI so it could be checked vs the PSP and Saturn versions.
Before submitting this for proper review, I'll rebase and clean up the commits on everything.
This PR also builds on (and incorporates) the commenting work in #3220 which is a real PR, related to cutscenes.