XLS-96 Confidential MPT#294
Draft
ckeshava wants to merge 3 commits intoXRPLF:mainfrom
Draft
Conversation
…m mpt-crypto Github CI
…he interfaces exported by mpt-crypto-sys with the typical guarantees of Rust.
…nfidential MPTs. What is remaining? - The integration tests pertaining to ConfidentialMPTs are not complete. - All the transaction+request models, binary-codec changes pertaining to MPTokensV1 is missing in xrpl-rust. This is a prereq for the above point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR materializes support for Confidential MPTs in the xrpl-rust library. Here are some salient points about the design choices:
stdin xrpl-rust SDK.verifier-methodsof mpt-crypto library are exposed, by unused.References:
Sister work in xrpl-py library: https://github.com/XRPLF/xrpl-py/pull/919/changes
mpt-crypto C library: https://github.com/XRPLF/mpt-crypto
Confidential Transfers specification: https://raw.githubusercontent.com/XRPLF/XRPL-Standards/refs/heads/master/XLS-0096-confidential-mpt/README.md
Type of Change
Test Plan
New tests will be added to verify all the new additions to the xrpl-rust SDK. This includes transaction-model related integration+unit tests. It also includes tests against the Rust-wrappers around the linkage of C-shared-library.