Type Game.status as GameStatus instead of str#248
Merged
Conversation
After #226, the field was declared `status: str = GameStatus.WAITING` — declared str, assigned enum. Mashumaro inspects the declared type when (de)serializing, so a round-trip would discard the enum and leave a plain str on the field. Verified by a quick PigGame.to_dict / from_dict probe before this change: deserialized as `str('playing')`; after this change: deserialized as `GameStatus.PLAYING`. Equality comparisons against raw strings continue to work because GameStatus inherits from str. The GameProtocol declaration is updated in lockstep. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #226 (review comment item 2). The field was left as
status: str = GameStatus.WAITING— declaredstr, assigned enum.Mashumaro looks at the declared type to (de)serialize, so a round-trip
would silently downcast the field to a plain
str.This PR changes the field and the
GameProtocoldeclaration tostatus: GameStatus. Equality comparisons against raw strings (theexisting pattern across game files) keep working via
GameStatus(str, Enum)'sstr inheritance.
Test plan
PigGame.to_dict() → from_dict()round-trip: before thischange the deserialized field was
str('playing'); after, it isGameStatus.PLAYING.pytest tests/test_event_handling_mixin.py tests/test_game_communication_mixin.py tests/test_pig.py tests/test_table_manager.py tests/test_keybinds.py tests/test_database.py tests/test_integration.py tests/test_server_tables_menus.py— 94 passed.cli.py simulate pig --bots 2 --test-serializationcompletes.🤖 Generated with Claude Code