Skip to content

Fix units orienting themselves cardinally on diagonal cover #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
furudee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix units orienting themselves cardinally on diagonal cover #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions X2WOTCCommunityHighlander/Src/XComGame/Classes/XComIdleAnimationStateMachine.uc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,11 +1997,15 @@ state EvaluateStance
// There may actually be no peekaround in the requested cover direction/peekside combination
if( DesiredPeekSide == ePeekLeft && Unit.GetCoverType(DesiredCoverIndex)!=CT_None)
{
DesiredFaceLocation = Unit.Location + `XWORLD.GetPeekLeftDirection(`IDX_TO_DIR(DesiredCoverIndex) , false) * 1000.0f;
/// HL-Docs: ref:Bugfixes; issue:1579
/// Units orient themselves on diagonal cover properly
// Issue #1579 - replace second parameter with `IS_DIAGONAL_COVER(Unit.GetCoverPoint())
DesiredFaceLocation = Unit.Location + `XWORLD.GetPeekLeftDirection(`IDX_TO_DIR(DesiredCoverIndex) , `IS_DIAGONAL_COVER(Unit.GetCoverPoint())) * 1000.0f;
}
else if( DesiredPeekSide == ePeekRight && Unit.GetCoverType(DesiredCoverIndex)!=CT_None)
{
DesiredFaceLocation = Unit.Location + `XWORLD.GetPeekRightDirection(`IDX_TO_DIR(DesiredCoverIndex) , false) * 1000.0f;
// Issue #1579 - replace second parameter with `IS_DIAGONAL_COVER(Unit.GetCoverPoint())
DesiredFaceLocation = Unit.Location + `XWORLD.GetPeekRightDirection(`IDX_TO_DIR(DesiredCoverIndex) , `IS_DIAGONAL_COVER(Unit.GetCoverPoint())) * 1000.0f;
}
// End Issue #269
else
Expand Down
Loading