Skip to content

Added a check (and fail) for post-cooking SDK cleanup #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xymanek merged 1 commit into from
Aug 11, 2021
+13 −0
Merged

Added a check (and fail) for post-cooking SDK cleanup #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions build_common.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,6 +1052,7 @@ class ModAssetsCookStep {
}
finally {
Write-Host "Cleaning up the asset cooking hacks"
$cleanupFailed = $false

# Revert ini
try {
Expand All @@ -1061,6 +1062,8 @@ class ModAssetsCookStep {
catch {
FailureMessage "Failed to revert $($this.sdkEngineIniPath)"
FailureMessage $_

$cleanupFailed = $true
}

# Revert junctions
Expand All @@ -1072,6 +1075,8 @@ class ModAssetsCookStep {
catch {
FailureMessage "Failed to remove $($this.cookerOutputPath) junction"
FailureMessage $_

$cleanupFailed = $true
}

if (![string]::IsNullOrEmpty($this.previousCookerOutputDirPath))
Expand All @@ -1087,8 +1092,16 @@ class ModAssetsCookStep {
catch {
FailureMessage "Failed to restore previous $($this.cookerOutputPath)"
FailureMessage $_

$cleanupFailed = $true
}
}

if ($cleanupFailed) {
Write-Host ""
Write-Host ""
ThrowFailure "Failed to clean up the asset cooking hacks - your SDK is now in a corrupted state. Please preform the cleanup manually before building a mod or opening the editor."
Comment thread
robojumper marked this conversation as resolved.
}
}
}

Expand Down