Add Black Bordered Radius Block Variation and Pattern About Page#211
Open
maurodf0 wants to merge 2 commits into
Open
Add Black Bordered Radius Block Variation and Pattern About Page#211maurodf0 wants to merge 2 commits into
maurodf0 wants to merge 2 commits into
Conversation
Add register block style for image with black bordered radius image.
Add Patterns, assets ad images folder, add about full page pattern, image use block style variation created in WordPress#211
maurodf0
changed the title
| array( | ||
| 'name' => 'bordered', | ||
| 'label' => __('Bordered', 'term'), | ||
| 'inline_style' => '.wp-block-image.is-style-bordered img{ |
Collaborator
There was a problem hiding this comment.
I don't think we should do this because we can already use the border controls on the image block. We only did it for the social icons because those controls are not there yet
Collaborator
There was a problem hiding this comment.
The reason being: a user can only opt in or out of the border radius, they can't tweak it to other values
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right, don't think about it, sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add register block style for image with black bordered radius image.