Build compatibility for later versions of node#14
Open
animetosho wants to merge 6 commits intoWoodya:masterfrom
Open
Build compatibility for later versions of node#14animetosho wants to merge 6 commits intoWoodya:masterfrom
animetosho wants to merge 6 commits intoWoodya:masterfrom
Conversation
Now compiles on Node v4, and presumably higher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-gzbz2 compiles on Node up to version 0.10.x, but the V8 API was significantly changed in 0.12.x and it won't compile on later versions of Node.
I've made some changes and it now compiles on Node version 4.x and presumably later versions. I haven't tested this on version 0.12.x or similar. Changes perhaps aren't the neatest, but it's hopefully better than not working at all.
I've also taken the liberty to fix up bzip2, as it wasn't linked in the gyp file.