Merged
Conversation
Author
|
Fix type relative priority of DNS servers. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the return type of the GetPropertyDnsPriority method from uint32 to int32 across both IPv4 and IPv6 configuration interfaces.
- Changed return type from
uint32toint32for DNS priority property getter - Updated both interface definitions and implementations to use signed integers
- Modified underlying property access methods to use
getInt32Propertyinstead ofgetUint32Property
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IP6Config.go | Updated IPv6 config interface and implementation to return int32 for DNS priority |
| IP4Config.go | Updated IPv4 config interface and implementation to return int32 for DNS priority |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.