Skip to content

fix type of GetPropertyDnsPriority#49

Merged
mullerch merged 1 commit intoWifx:masterfrom
IvanOrfanidi:fix/GetPropertyDnsPriority
Oct 2, 2025
Merged

fix type of GetPropertyDnsPriority#49
mullerch merged 1 commit intoWifx:masterfrom
IvanOrfanidi:fix/GetPropertyDnsPriority

Conversation

@IvanOrfanidi
Copy link

No description provided.

@IvanOrfanidi
Copy link
Author

IvanOrfanidi commented Sep 25, 2025

Fix type relative priority of DNS servers.
Replacement uint32 to int32. For dbus api nm.
Bug: Always returned 0 for relative priority.

@IvanOrfanidi IvanOrfanidi changed the title fix GetPropertyDnsPriority fix type of GetPropertyDnsPriority Sep 25, 2025
@mullerch mullerch requested a review from Copilot October 2, 2025 08:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the return type of the GetPropertyDnsPriority method from uint32 to int32 across both IPv4 and IPv6 configuration interfaces.

  • Changed return type from uint32 to int32 for DNS priority property getter
  • Updated both interface definitions and implementations to use signed integers
  • Modified underlying property access methods to use getInt32Property instead of getUint32Property

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
IP6Config.go Updated IPv6 config interface and implementation to return int32 for DNS priority
IP4Config.go Updated IPv4 config interface and implementation to return int32 for DNS priority

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mullerch mullerch merged commit 7f68a9f into Wifx:master Oct 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants