Simplify notifications: drop Read state, suppress deploy noise#366
Merged
Wiesenwischer merged 1 commit intomainfrom Apr 17, 2026
Merged
Simplify notifications: drop Read state, suppress deploy noise#366Wiesenwischer merged 1 commit intomainfrom
Wiesenwischer merged 1 commit intomainfrom
Conversation
- Remove Read flag from Notification; merge read/dismissed into a single lifecycle so notifications stay in the dropdown until dismissed. - API: remove mark-as-read and mark-all-as-read endpoints, rename /api/notifications/unread-count to /count, add DELETE /api/notifications for bulk dismiss. - HealthChangeTracker gains suppressNotifications flag (passed from HealthCollectorService when Deployment.IsInProgress) and a ResetBaselineAsync hook so the tracker clears tracked baselines whenever a deployment leaves Running. After redeploy/upgrade the first recovery cycle now starts from a clean baseline and no longer emits spurious pre-upgrade -> post-upgrade transition notifications. - Frontend: NotificationDropdown shows every visible notification with the same styling, replaces "Mark all as read" with "Dismiss all", and drops read/unread fields from the core API client and hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pain points in the notification dropdown addressed together:
HealthChangeTrackerfiring one notification per service per transition. Two mitigations:ProcessHealthUpdateAsyncnow acceptssuppressNotifications, wired fromDeployment.IsInProgressinHealthCollectorService(defensive — the Running-only filter would already block today, but keeps the intent explicit).ResetBaselineAsynchook, called wheneverHealthCollectorServiceencounters a deployment in any non-Running status. After redeploy/upgrade, the first recovery cycle starts from a clean baseline and no longer emits spurious pre-upgrade → post-upgrade transition notifications.Breaking API changes
Notification.Readfield removed.POST /api/notifications/{id}/read— removed.POST /api/notifications/read-all— removed.GET /api/notifications/unread-count→GET /api/notifications/count.DELETE /api/notifications— added.AMS UI consumes
@rsgo/corevia file-link and must be updated in lockstep. A companion plan lives atReadyStackGo.Ams/docs/Plans/PLAN-notification-simplification.md.Test plan
dotnet build— 0 errors, 5 pre-existing warnings.dotnet test— 2876 tests pass, including new cases forSuppressNotifications,ResetBaseline(fresh-baseline, scoped-to-target, unknown-deployment).pnpm -r buildinsrc/ReadyStackGo.WebUi— green.ProductDeploymentResultlands (no per-service HealthChange spam).NotificationDropdown.tsxbefore releasing a combined distribution.