Fix: wire maintenance observer config onto ProductDeployment#365
Merged
Wiesenwischer merged 1 commit intomainfrom Apr 15, 2026
Merged
Fix: wire maintenance observer config onto ProductDeployment#365Wiesenwischer merged 1 commit intomainfrom
Wiesenwischer merged 1 commit intomainfrom
Conversation
MaintenanceObserverService reads productDeployment.MaintenanceObserverConfig, but ProductDeployment.SetMaintenanceObserverConfig had zero production callers. DeployStackHandler mapped the config correctly but only wrote it to the stack-level Deployment entity, which nothing reads. Result: no observer was ever instantiated for any product, so maintenanceObserver blocks in stack.yaml were silently ignored regardless of their content. - Extract MaintenanceObserverConfigMapper as a shared helper in Application.Services - DeployProductHandler: resolve and attach observer config on InitiateDeployment - RedeployProductHandler: re-read the product from catalog and refresh observer config on redeploy so stack.yaml edits to maintenance.observer take effect - Tests cover resolvable/unresolvable/missing observer paths for both handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaintenanceObserverServicereadsproductDeployment.MaintenanceObserverConfig, butProductDeployment.SetMaintenanceObserverConfighad zero production callers.DeployStackHandlermapped the config correctly but only wrote it to the stack-levelDeploymententity, which nothing reads.maintenance.observerblocks instack.yamlwere silently ignored regardless of content, soChangeProductOperationModevia observer never fired.MaintenanceObserverConfigMapperas a shared helper inApplication.Services, wire it fromDeployProductHandler(initial deploy) andRedeployProductHandler(refresh from catalog sostack.yamledits take effect on redeploy).Test plan
dotnet build— 0 errorsdotnet test— 2877/2877 passingDeployProductHandlersets observer config on the ProductDeployment when resolvable; leaves it null when placeholders cannot be resolved; leaves it null when no observer definedRedeployProductHandlerre-reads observer config from catalog on redeploy; clears config when observer removed from catalogsqlExtendedPropertyobserver, flip the extended property, confirm the product transitions into maintenance within the polling interval