refactor(desktop): modularize desktop main process#365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desktop/main.jsinto responsibility-based modules for config, local stores, workspace state, research_ui lifecycle, Stepbit chat, smoke support, window creation, and IPC registration.main.jsto app lifecycle wiring and service composition.Issue
Why
Scope
This PR does not:
Validation
Validated with:
npm run typechecknode --check main.jsGet-ChildItem desktop/main/*.js | ForEach-Object { node --check $_.FullName }node --check preload.jsnode --check renderer/app.jsnpm run smoke:fallbacknpm run smoke:real-pathDuplication Check
Compatibility / Risk
Notes
smoke:fallbackfailed once locally with a transientUnexpected end of JSON input, then passed on rerun; the final validated run is green.