Skip to content

fix(desktop): align snapshot refresh status semantics#364

Merged
Whiteks1 merged 1 commit intomainfrom
codex/issue-361-snapshot-status-alignment
Apr 10, 2026
Merged

fix(desktop): align snapshot refresh status semantics#364
Whiteks1 merged 1 commit intomainfrom
codex/issue-361-snapshot-status-alignment

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

Summary

  • align desktop snapshot refresh labels with the shared idle | ok | degraded | error contract
  • stop treating healthy ok snapshots as an implicit waiting state
  • add a small node:test regression for the snapshot label and tone mapping

Issue

Why

  • the shared desktop snapshot contract already changed, but the renderer still expected stale ready / loading values
  • that let the UI mislabel healthy runtime state without breaking the shell
  • this slice restores one truthful vocabulary across the shared model and renderer

Scope

This PR does not:

  • refactor broader desktop UX
  • change engine/core contracts outside the snapshot boundary
  • alter smoke semantics or architecture slices unrelated to snapshot status mapping

Validation

Validated with:

  • npm run typecheck
  • node --check renderer/app.js
  • node --check renderer/modules/tab-renderers.js
  • node --test tests/snapshot-status.test.mjs
  • npm run smoke:fallback
  • PYTHON=C:\Users\marce\Documents\QUANT LAB PERSONAL\quant_lab\.venv\Scripts\python.exe npm run smoke:real-path

Duplication Check

  • I searched for an existing issue covering this mismatch.
  • I treated the shared snapshot model as the source of truth instead of introducing alternate status names.
  • I kept the regression coverage local to the affected desktop runtime mapping.

Compatibility / Risk

  • healthy ok snapshots now render as Live instead of falling through to Waiting
  • degraded and error remain distinct operator states instead of collapsing into the same branch
  • the main risk is only visible-label drift in existing screenshots or expectations, which is the bug being corrected here

Notes

  • local smoke:real-path in this clean worktree needed the canonical repo venv via PYTHON=...\.venv\Scripts\python.exe; the slice itself does not change desktop bootstrap rules

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Whiteks1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Whiteks1 Whiteks1 merged commit 1179cd7 into main Apr 10, 2026
3 checks passed
@Whiteks1 Whiteks1 deleted the codex/issue-361-snapshot-status-alignment branch April 10, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

desktop(runtime): align snapshot status contract with renderer semantics

1 participant