fix(desktop): align snapshot refresh status semantics#364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idle | ok | degraded | errorcontractoksnapshots as an implicit waiting statenode:testregression for the snapshot label and tone mappingIssue
Why
ready/loadingvaluesScope
This PR does not:
Validation
Validated with:
npm run typechecknode --check renderer/app.jsnode --check renderer/modules/tab-renderers.jsnode --test tests/snapshot-status.test.mjsnpm run smoke:fallbackPYTHON=C:\Users\marce\Documents\QUANT LAB PERSONAL\quant_lab\.venv\Scripts\python.exe npm run smoke:real-pathDuplication Check
Compatibility / Risk
oksnapshots now render asLiveinstead of falling through toWaitingdegradedanderrorremain distinct operator states instead of collapsing into the same branchNotes
smoke:real-pathin this clean worktree needed the canonical repo venv viaPYTHON=...\.venv\Scripts\python.exe; the slice itself does not change desktop bootstrap rules